From: Antonin Houska <ah@cybertec.at>
cc: shihao zhong <zhong950419@gmail.com>,
    Alvaro Herrera <alvherre@kurilemu.de>,
    Fujii Masao <masao.fujii@gmail.com>,
    Radim Marek <radim@boringsql.com>,
    PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: REPACK (CONCURRENTLY) might keep dropped-column data
In-reply-to: <12438.1791272113@localhost>
References: 
 <CAHGQGwG9bHxhs4Nj+9avSjSGh0vdYNQgEuz+pmJ-H5be6tEBTw@mail.gmail.com>
 <asOEsmPw75ifqMua@alvherre.pgsql>
 <CAGRkXqTxse0sTb43z3kFAHDrffjkamHkFGfoLEtwRkr_QfDGGg@mail.gmail.com>
 <12438.1791272113@localhost>
Comments: In-reply-to Antonin Houska <ah@cybertec.at>
   message dated "Tue, 06 Oct 2026 09:35:13 +0200."
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Date: Tue, 06 Oct 2026 12:44:12 +0200
Message-ID: <31417.1791283452@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/31417.1791283452%40localhost>
Precedence: bulk

--=-=-=
Content-Type: text/plain

Antonin Houska <ah@cybertec.at> wrote:

> shihao zhong <zhong950419@gmail.com> wrote:
> 
> > It can also make REPACK fail. If the columns that are left need no
> > TOAST table, the new heap has none, and on master I get:
> > 
> > ERROR:  row is too big: size 16424, maximum size 8160
> 
> Can you please be more specific about this? I don't understand why the new
> heap has no TOAST relation in such a case. Perhaps a bug in see
> heapam_relation_needs_toast_table()? I'm not sure it should return here,
> regardless the tuple size.
> 
> 	if (!has_toastable_attrs)
> 		return false;			/* nothing to toast? */

I could reproduce error like this independently from REPACK - see the scripts
attached. However, I realize that it does not help to remove this part from
heapam_relation_needs_toast_table(): it would only enforce creation of the
TOAST table if all the attributes had storage TYPSTORAGE_PLAIN, but such
attributes cannot be TOASTed anyway.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com


--=-=-=
Content-Type: application/gzip
Content-Disposition: attachment; filename=create.sql.gz
Content-Transfer-Encoding: base64

H4sICNLLxGoAA2NyZWF0ZS5zcWwAXdy7jiVFEAZhn6fABAmj/qrMuoiHQQvCQFqBBPv+AqyJGAcd
rKy9fdN9OqN/+/v3L99+//7bl1+//vffH7777a+v4/s//vx2f/r/Yz4+zo+P6+NjfXzsj4/74+P5
+Hg/Pj6M4DjMCwYGE4ORwcxgaDA1GBvMnZg7+evE3Im5E3Mn5k7MnZg7MXdi7sLchbmLv8GYuzB3
Ye7C3IW5C3MX5hbmFuYW5hb/ZDG3MLcwtzC3MLcwtzG3MbcxtzG3+VcKcxtzG3MbcxtzN+ZuzN2Y
uzF3Y+7m32XM3Zi7MXdj7sHcg7kHcw/mHsw9mHv4jwhzD+YezL2YezH3Yu7F3Iu5F3Mv5l7+68Xc
i7kPcx/mPsx9mPsw92Huw9yHuY9syA3CMSjHIB2DdgziMajHIB+DfgwCMngC08UTCC/pJb7klwCT
YCKMhoWIZUpPnoCOhZCFkoWUhZaFmIWahZyFnmUJcJ6ApIWmhaiFqoWsha6FsIWyhbSl9DOEJ6Bu
IW+hbyFwoXAhcaFxIXKhcmn9GOMJCF0oXUhdaF2IXahdyF3oXQhetn6S8gQ0L0QvVC9kL3QvhC+U
L6QvtC9HP8x5AvIX+hcCGAoYEhgaGCIYKhgymKvrCZ6AEoYUhhaGGIYahhyGHoYghiLm6ZJG1zS8
qKGJkyZOmjhp4qSJkyZOmjhp4qSJM7qs4glo4qSJkyZOmjhp4qSJkyZOXdfpws5XdjyBru10caer
O13e6fpOF3g0cdLESRPn0sUlT0ATJ02cNHHSxEkTJ02cNHHSxEkTZ+n6liegiZMmTpo4aeKkiZMm
Tpo4aeKkibN1ic0T0MRJEydNnDRx0sRJEydNnDRx0sS5dZXPE9DESRMnTZw0cdLESRMnTZw0cdLE
eXSjwRPQxEkTJ02cNHHSxEkTJ02cNHHSxHl1r8MT0MRJEydNnDRx0sRJEydNnDRx0sT5dLul+y3e
cNHERRMXTVw0cdHERRMXTVw0cdHEFd3y8QQ0cdHERRMXTVw0cdHERRMXTVw0cU3ddfIENHHRxEUT
F01cNHHRxKW7Xt326r7XN748gW59de+rm1/d/er2lyYumrho4qKJq3TvzRPQxEUTF01cNHHRxEUT
F01cNHHRxNW6/ecJaOKiiYsmLpq4aOKiiYsmLpq4aOKiiYsmLpq4aOKiiYsmLpq4aOKiiYsmLpq4
aOKiiYsmLpq4aOKiiYsmLpq4aOKiiYsmLpq4aOKiiYsmLpq4aOKiiYsmLpq4aOKiiYsmLppYNLFo
YtHEoolFE4smFk0smlg0sWhi0cSiiUUTiyYWTSyaWDSxaGLRxKKJRROLJhZNLJpYNLFoYtHEoolF
E4smFk0smlg0sWhi0cSiiUUTiyYWTSx9J6gvBfWtoL4W9PeCPIG+GdRXg/puUF8O0sSiiUUTiyYW
TSyaWDSxaGLRxKKJRROLJhZNLJpYNLFoYtHEoolFE4smFk0smlg0sWhi0cSiiUUTiyYWTSyaWDSx
aGLRxKKJRROLJhZNLJpYNLFoYtHEoolFE4smFk0smlg0sWhi0cSiiUUTmyY2TWya2DSxaWLTxKaJ
TRObJjZNbJrYNLFpYtPEpolNE5smNk1smtg0sWli08SmiU0TmyY2TWya2DSxaWLTxKaJTRObJjZN
bJrYNLFpYtPEpolNE5smNk1smtg0sWli08SmiU0Tmya2npjokYmemeihiZ6a+LEJT6AHJ3pyokcn
NLFpYtPEpolNE5smNk1smtg0sWli08SmiU0TmyY2TWya2DSxaWLTxKaJTRObJjZNbJrYNLFpYtPE
polNE5smNk1smtg0sWli08SmiU0TmyY2TWya2DRx08RNEzdN3DRx08RNEzdN3DRx08RNEzdN3DRx
08RNEzdN3DRx08RNEzdN3DRx08RNEzdN3DRx08RNEzdN3DRx08RNEzdN3DRx08RNEzdN3DRx08RN
EzdN3DRx08RNEzdN3DRx08RNEzdN3DRx08RNEzdN3DRx08RNEzdN3DRx08RNEzdN3HqerAfKeqKs
R8p6pqyHyn6qzBPoubIeLNPETRM3Tdw0cdPETRM3Tdw0cdPETRM3Tdw0cdPETRM3Tdw0cdPETRM3
Tdw0cdPETRM3Tdw0cdPETRM3Tdw0cdPETRM3TTw08dDEQxMPTTw08dDEQxMPTTw08dDEQxMPTTw0
8dDEQxMPTTw08dDEQxMPTTw08dDEQxMPTTw08dDEQxMPTTw08dDEQxMPTTw08dDEQxMPTTw08dDE
QxMPTTw08dDEQxMPTTw08dDEQxMPTTw08dDEQxMPTTw08dDEQxMPTTw08dDEQxMPTTw08dDEQxMP
TTw08dDEQxMPTTw08WjbRus22rfRwo02brRyo50bL93wBFq7oYmHJh6aeGjioYmHJh6aeGjioYmH
Jh6aeGjioYmHJh6aeGjioYmHJh6aeGjioYmXJl6aeGnipYmXJl6aeGnipYmXJl6aeGnipYmXJl6a
eGnipYmXJl6aeGnipYmXJl6aeGnipYmXJl6aeGnipYmXJl6aeGnipYmXJl6aeGnipYmXJl6aeGni
pYmXJl6aeGnipYmXJl6aeGnipYmXJl6aeGnipYmXJl6aeGnipYmXJl6aeGnipYmXJl6aeGnipYmX
Jl6aeGnipYmXJl6aeGnipYmXJl6aeGnipYmXJl6aeGni1S6ilhG1jah1RO0jaiFRG4laSfROIk9A
Ey9NvDTx0sRLEy9NvDTx0sRLEy9NvDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9N
fDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx
0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRH
Ex9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx0cRHEx9NfDTx0cSnTW2t
amtXW8va2tbWurb2tbWwrY1tr2x7Z1tL297a9tq297a9uO3Nba9ue3fby9va3h5a3x7a3x5a4B7a
4B5a4R7a4R5a4h7a4h5a4x7a4x5a5B7a5B5a5R7a5R5a5h7a5h5a5x7a5x5a6B7a6B5a6R7a6R5a
6h7a6h5a6x7a6x5a7B7a7B5a7R7a7R5a7h7a7h5a7x7a7x5a8B7a8B5a8R7a8R5a8h7a8h5a8x7a
8x5a9B7a9B5a9R7a9R5a9h7a9h5a9x7a9x5a+B7a+B5a+R7a+R5a+h7a+h5a+x7a+x5a/B7a/B5a
/R7a/R5a/h7a/h5a/x7a/x5aAB/aAB9aAR/aAR9aAh/aAh9aAx/aAx9aBB/aBB9aBR/aBR9aBh/a
Bh9aBx/aBx9aCB/aCB9aCR/aCR9aCh/aCh9aCx9y17GMaxnnMu5lHMy4mHEy42bG0cynauZTNqOz
OJxxOeN0xu2M4xnXM85n5K4DGhc0Tmjc0DiicUXjjMYdjUMalzROadzSOKZxTeOcxj2NgxoXNU5q
3NQ4qnFV46zGXY3DGpc1Tmvc1jiucV3jvMZ9jQMbFzZObNzYOLJxZePMxp2NQxuXNk5t3No4tnFt
49zGvY2DGxc3Tm7c3Di6cXXj7MbdjcMblzdOb9zeOL5xfeP8xv2NAxwXOE5w3OA4wnGF4wzHHY5D
HJc4TnHc4jjGcY3jHEc9ThTkREVOlORETU4U5URVTpTlRF1OFOZEZU6U5mS6tZa7qnOiPCfqc6JA
Jyp0okQn092iw8VP5aLO4nbR8aLrReeL7hcdMMpd5TpRrxMFO1GxEyU7UbMTRTtRtRNlO1G3E4U7
UbkTpTtRuxPFO1G9E+U7Ub8TBTxRwRMlPFHDE0U8UcUTZTxRxxOFPFHJE6U8UcsTxTxRzRPlPFHP
EwU9UdETJT1R0xNFPVHVE2U9UdcThT1R2ROlPVHbE8U9Ud0T5T1R3xMFPlHhEyU+UeMTRT5R5RNl
PlHnE4U+UekTpT5R6xPFPlHtE+U+Ue8TBT9R8RMlP1HzE0U/UfUTZT9R9xOFP1H5E6U/UfsTxT9R
/RPlP1H/k+W3XMhdJUBRAxRFQFEFFGVAUQcUhUBRCRSlQFELFMVAUQ0U5UBRDxQFQVkux52Oux3/
FI/rLM7H3Y87IHdB7oRc7ioOiuqgKA+K+qAoEIoKoSgRihqhKBKKKqEoE4o6oSgUikqhKBWKWqEo
FopqoSgXinqhKBiKiqEoGYqaoSgaiqqhKBuKuqEoHIrKoSgditqhKB6K6qEoH4r6oSggigqiKCGK
GqIoIooqoigjijqiKCSKSqIoJYpaoigmimqiKCeKeqIoKIqKoigpipqiKCqKqqIoK4q6oigsisqi
KC2K2qIoLorqoigvivqiKDCKCqMoMYoaoygySvn9QnJXnVEUGkWlUZQaRa1RFBtFtVGUG0W9URQc
RcVRlBxFzVEUHUXVUZQdRd1RFB5F5VGUHkXtURQfRfVRlB+l/O4Ov7zDb+/w6zs+vb9DZ/EbPPwK
D7/Dwy/xkLtKkaIWKYqRohopypGiHikKkqIiKUqSoiYpipKiKinKkqIuKQqTojIpSpOiNimKk6I6
KcqToj4pCpSiQilKlKJGKYqUokopypSiTikKlaJSKUqVolYpipWiWinKlaJeKQqWomIpSpaiZimK
lqJqKcqWom4pCpeicilKl6J2KYqXonopypeifikKmKKCKUqYooYpipiiiinKmKKOKQqZopIp7Te7
yV3FTFHNFOVMUc8UBU1R0RQlTVHTFEVNUdUUZU1R1xSFTVHZFKVNUdsUxU1R3RTlTVHfFAVOUeEU
JU5R4xRFTlHlFGVOUecUhU5R6RSlTlHrFMVOab89ya9P8vuT/AIlv0Hp0yuUdBa/RMlvUfJrlOSu
wqeofIrSp6h9iuKnqH6K8qeof4oCqKiAihKoqIGKIqiogooyqKiDikKoqISKUqiohYpiqKiGinKo
qIeKgqioiIqSqKiJiqKoqIqKsqioi4rCqKiMitKoqI2K4qiojoryqF++fvnn2///++PP3/0LL/E/
fDtTAAA=
--=-=-=
Content-Type: application/gzip
Content-Disposition: attachment; filename=insert.sql.gz
Content-Transfer-Encoding: base64

H4sICPXLxGoAA2luc2VydC5zcWwA7cKxCYAwEADA3im+VLCwdxqLFIEQwXyc3zUs7rjaR3kyas87
Mt6rzTJiPfZQVVVV1Z/ezuUDKbBSydcSAAA=
--=-=-=--