From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
cc: Stepan <sndcppg@gmail.com>,
        "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: SPI_connect, SPI_connect_ext return type
In-reply-to: <CAKFQuwZLscENsYRvCAo5DqLAfD8zLNoA006JYuQCdXNOR2wvOw@mail.gmail.com>
References: <CAMaYL5Z9Uk8cD9qGz9QaZ2UBJFOu7jFx5Mwbznz-1tBbPDQZow@mail.gmail.com> <3133982.1723299124@sss.pgh.pa.us> <CAKFQuwZLscENsYRvCAo5DqLAfD8zLNoA006JYuQCdXNOR2wvOw@mail.gmail.com>
Comments: In-reply-to "David G. Johnston" <david.g.johnston@gmail.com>
	message dated "Sat, 10 Aug 2024 08:18:31 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3155776.1723307344.1@sss.pgh.pa.us>
Date: Sat, 10 Aug 2024 12:29:04 -0400
Message-ID: <3155777.1723307344@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3155777.1723307344%40sss.pgh.pa.us>
Precedence: bulk

"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Saturday, August 10, 2024, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> That would break a lot of code (much of it not under our control) to
>> little purpose; it would also foreclose the option to return to using
>> SPI_ERROR_CONNECT someday.

> I suggest we document it as deprecated and insist any future attempt to
> implement a return-on-error connection function define a completely new
> function.

True; we're kind of in an intermediate place right now where certain
call sites aren't bothering to check the return code, but it's hard
to argue that they're really wrong --- and more to the point,
re-introducing use of SPI_ERROR_CONNECT would break them.  I don't
know if that usage pattern has propagated outside Postgres core,
but it might've.  Perhaps it would be better to update the docs to
say that the only return value is SPI_OK_CONNECT and all failure
cases are reported via elog/ereport.

			regards, tom lane