Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1uWd81-00GeM4-GJ
	for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Jul 2025 15:42:37 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1uWd7z-006ahi-Ix
	for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Jul 2025 15:42:36 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1uWd7z-006ahS-90
	for pgsql-hackers@lists.postgresql.org; Tue, 01 Jul 2025 15:42:35 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1uWd7y-004ySj-0z
	for pgsql-hackers@lists.postgresql.org;
	Tue, 01 Jul 2025 15:42:35 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 561FgSsW3167014;
	Tue, 1 Jul 2025 11:42:28 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Tomas Vondra <tomas@vondra.me>, Evgeniy Gorbanev <gorbanyoves@basealt.ru>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: No error checking when reading from file using zstd in pg_dump
In-reply-to: <69A4E455-94E6-4348-9007-D7CCBA0E2D40@yesql.se>
References: <6b9817a8-88ec-4efd-b441-9e2a0439c6b8@basealt.ru>
 <C22FF2A1-783D-4334-998B-2D4432EFD7C5@yesql.se>
 <95255a86-4bc7-4ff4-aa26-4441aafdf0fb@basealt.ru>
 <522DB522-3962-4F91-A691-2DE790F6CCD6@yesql.se>
 <b653a2f4-1dcb-45ba-b899-fc6aa80794f2@basealt.ru>
 <D38B293E-E886-4F0D-BD5A-C958DCB2344C@yesql.se>
 <e2b7edd1-c5b8-484d-9c79-7a7c4466fad2@basealt.ru>
 <517794.1750082166@sss.pgh.pa.us>
 <3815B6CD-924B-40FA-823A-55E2F8F24602@yesql.se>
 <520142.1750083607@sss.pgh.pa.us>
 <D011594F-7FA3-4BE4-BF89-B1AB18CD3456@yesql.se>
 <644360.1750096605@sss.pgh.pa.us>
 <f2dec453-b6af-4495-a75d-a39628411510@vondra.me>
 <666035.1750106940@sss.pgh.pa.us>
 <EBEE0042-E30B-43CB-8BAA-F51908248928@yesql.se>
 <1296195.1750867134@sss.pgh.pa.us>
 <A9EB5A06-6C77-418B-B582-AFE5F027B4B3@yesql.se>
 <1448707.1750944836@sss.pgh.pa.us>
 <BBC4C1E4-EA6D-40E6-9FB9-1D917F2D1B20@yesql.se>
 <69A4E455-94E6-4348-9007-D7CCBA0E2D40@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Tue, 01 Jul 2025 16:24:40 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3167012.1751384548.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 01 Jul 2025 11:42:28 -0400
Message-ID: <3167013.1751384548@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/3167013.1751384548%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> In preparing for concluding this I've attached a v8 which is the patchse=
t in v7
> squashed into a single commit with an attempt at a commit message.

Glancing through this, I observe a couple of minor typos:

+     * Returns number of bytes read (this might be less than 'size' if EO=
F was
+     * reached).  Exits via pg_fatal all for error conditions.

s/all for/for all/

+        pg_fatal("coud not write to file: %m");

s/coud/could/

There are some minor typos in the proposed commit message, too.

			regards, tom lane