Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6bp4-0002Ly-4W for pgsql-hackers@arkaria.postgresql.org; Fri, 05 May 2017 11:54:58 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d6bp3-0002ix-NU for pgsql-hackers@arkaria.postgresql.org; Fri, 05 May 2017 11:54:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d6bnX-00085W-HQ for pgsql-hackers@postgresql.org; Fri, 05 May 2017 11:53:23 +0000 Received: from mail-wr0-x232.google.com ([2a00:1450:400c:c0c::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d6bnT-0002ci-BT for pgsql-hackers@postgresql.org; Fri, 05 May 2017 11:53:23 +0000 Received: by mail-wr0-x232.google.com with SMTP id l9so2442821wre.1 for ; Fri, 05 May 2017 04:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=PiDFWvM3u2F1m5elVwjuv3+J0YjUx+1eCb+97uUQ/AI=; b=mptTImP9oyDFZec/vXoEC28ZGGduHzim7f2ugIlOaCLmJUaR9ZW3lIlMFf6vlf8J5Y /iuQTEE37Z1esOO/rU7EfIA7sy4njsPcTsL2mgta+yvJ/5Eqa+LlnemNiBhBGDI8czJn q40QeVdaajMSiIU2aLKvp4Wmt4wtFIpcFiVqDaXaAFySkIMgHHh/OdE8fl7FvkqoHpZ0 iC/0sPHfiE35OItywuECqcJ7sbGDLsiROWRh1CK2hm0xoE8JN4KO4gKT0gP/dBOvALww ySxSGN+y/eixdXa/4epQQmDFfmGqTeOWMY0UJiO8IklKW0PmdUSiJ9rn872540IqKWQG 4qow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=PiDFWvM3u2F1m5elVwjuv3+J0YjUx+1eCb+97uUQ/AI=; b=pG1xfWJalzss1sQBeEFr5yh2RN/GglED6+/L8Nu79Xo3qs1HeOdyWAM8DJat1Cyhm2 Rebe+q2CC2PRm5qe1/mJDSOxeXiSDdg8AslqT2A0jwNmEqiKLBLFtSi/7idCEsf4AdqZ EIRWhLeP/Jj19jpzJSUXXA2K4BXU6dVVgSqAWenoz/gb7EF6zcnMaVU2qRM2jxrvEOZu R9fKtY4iWF4ikE1eI3Lfa1HhszA+IxNY+B5CKM2a9P93MiK4CCIOaxtjKvTAyY+jlhth +e01Tx4HIUmr7PXAuZcnOpLGT16r/6LMopBM6v6XY7HfFSzAmXLSiXNo3aTUu3TOfwYi ps6g== X-Gm-Message-State: AN3rC/62enFTqGAtXEPtMul9Qcr55Q5n0pAW5rj4FTicVaIqozms3EaY d/0lqykaB6wSwyU96OKmrA== X-Received: by 10.223.134.46 with SMTP id 43mr35684262wrv.123.1493985198594; Fri, 05 May 2017 04:53:18 -0700 (PDT) Received: from [192.168.0.105] (150.123.broadband11.iol.cz. [90.178.123.150]) by smtp.gmail.com with ESMTPSA id 8sm4749623wrb.55.2017.05.05.04.53.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 May 2017 04:53:17 -0700 (PDT) Subject: Re: snapbuild woes To: Andres Freund References: <0d06dfc1-0bc5-c3ab-3555-24e2f275d7fa@2ndquadrant.com> <30242bc6-eca4-b7bb-670e-8d0458753a8c@2ndquadrant.com> <20170501005921.qcqd7w2njpv3av6s@alap3.anarazel.de> <20170501013529.sejtgo2acxbvq26q@alap3.anarazel.de> <209861fc-718f-0a7b-3a1d-36512865c209@2ndquadrant.com> <20170501080348.vb6mj5whdex3f7l7@alap3.anarazel.de> <20170501191419.coqbtx2jodu22ufz@alap3.anarazel.de> <20170505000004.gihrtl7bhxeolf3q@alap3.anarazel.de> <20170505004237.edtahvrwb3uwd5rs@alap3.anarazel.de> Cc: PostgreSQL-development , Erik Rijkers , Robert Haas , Craig Ringer From: Petr Jelinek Message-ID: <316d270d-d97e-65ba-dcdd-34f6b13698f6@2ndquadrant.com> Date: Fri, 5 May 2017 13:53:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170505004237.edtahvrwb3uwd5rs@alap3.anarazel.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 05/05/17 02:42, Andres Freund wrote: > On 2017-05-04 17:00:04 -0700, Andres Freund wrote: >> Attached is a prototype patch for that. > I am not sure I understand the ABI comment for started_collection_at. What's the ABI issue? The struct is private to snapbuild.c module. Or you want to store it in the ondisk snapshot as well? About better name for it what about something like oldest_full_xact? Otherwise the logic seems to be right on first read, will ponder it a bit more -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers