Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jvqCa-0007Ri-GB
	for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jul 2020 22:48:36 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jvqCY-0007om-Ce
	for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jul 2020 22:48:34 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jvqCY-0007oX-4W
	for pgsql-hackers@lists.postgresql.org; Wed, 15 Jul 2020 22:48:34 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jvqCV-0007r2-64
	for pgsql-hackers@lists.postgresql.org; Wed, 15 Jul 2020 22:48:32 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 06FMmS7p3179115;
	Wed, 15 Jul 2020 18:48:29 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
cc: rosset.filipe@gmail.com
Subject: sys_siglist[] is causing us trouble again
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3179113.1594853308.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 15 Jul 2020 18:48:28 -0400
Message-ID: <3179114.1594853308@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

As of a couple days ago, buildfarm member caiman (Fedora rawhide)
is failing like this in all the pre-v12 branches:

ccache gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-=
statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno=
-strict-aliasing -fwrapv -fexcess-precision=3Dstandard -Wno-format-truncat=
ion -Wno-stringop-truncation -g -O2 -DFRONTEND -I../../src/include -D_GNU_=
SOURCE -I/usr/include/libxml2   -c -o wait_error.o wait_error.c
wait_error.c: In function \342\200\230wait_result_to_str\342\200\231:
wait_error.c:71:6: error: \342\200\230sys_siglist\342\200\231 undeclared (=
first use in this function)
   71 |      sys_siglist[WTERMSIG(exitstatus)] : "(unknown)");
      |      ^~~~~~~~~~~
wait_error.c:71:6: note: each undeclared identifier is reported only once =
for each function it appears in
make[2]: *** [<builtin>: wait_error.o] Error 1

We haven't changed anything, ergo something changed at the OS level.

Oddly, we'd not get to this code unless configure set
HAVE_DECL_SYS_SIGLIST, so it's defined *somewhere*.  I suspect the root
issue here is some rearrangement of system header files combined with
wait_error.c (and maybe other places?) not including exactly the same
headers that configure tested.

Anyway, rather than installing rawhide and trying to debug this,
I'd like to make a modest proposal: let's back-patch the v12
patches that made us stop relying on sys_siglist[], viz a73d08319
and cc92cca43.  Per the discussions that led to those patches,
it's been decades since any platform didn't have POSIX-compliant
strsignal(), so we'd be much better off relying on that.

			regards, tom lane