Message-ID: <3184af6f-75a2-4b43-8223-897b71970fef@vondra.me>
Date: Fri, 10 Jul 2026 02:05:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: s/pg_attribute_always_inline/pg_always_inline/?
To: Tom Lane <tgl@sss.pgh.pa.us>, David Rowley <dgrowleyml@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>,
 Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers@postgresql.org
References: <bqqdehahpoa36igpictuqyn2s2mexk3t3ehidh2ffd2slb35e5@rzgksuiszgbg>
 <56def459-2b95-42bc-b4e4-26e57f08b064@eisentraut.org>
 <ovpakrvg3mfwyumhkrxjgnwfb75jo534booip7pqrq7cjt4orj@vydvdlbscnx4>
 <CAH2-WznHSUJcV47OhoisvABjN2xjVOYh0_bRagUE6ir5zGJzow@mail.gmail.com>
 <adee40b0-ee0d-40a8-abe7-61784db3ec6c@vondra.me>
 <CAH2-Wzm3ev6uGsf4QddpaZamzsb3ATvanggEHxnhRSkdd52bnA@mail.gmail.com>
 <4370bec0-df13-40f3-92ee-75974182e41f@vondra.me>
 <CAApHDvpwjsxBYEsLLj5Z==zqZK4JZn2S_uc0Pi3dGACSsgOQyw@mail.gmail.com>
 <2391698.1783556089@sss.pgh.pa.us>
Content-Language: en-US
From: Tomas Vondra <tomas@vondra.me>
In-Reply-To: <2391698.1783556089@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/3184af6f-75a2-4b43-8223-897b71970fef%40vondra.me>
Precedence: bulk

On 7/9/26 02:14, Tom Lane wrote:
> David Rowley <dgrowleyml@gmail.com> writes:
>> On Thu, 9 Jul 2026 at 09:42, Tomas Vondra <tomas@vondra.me> wrote:
>>> I guess we should just commit that, so unless someone objects soon I'll
>>> just do that. ISTM the agreement is to backpatch this too.
> 
>> How about just backpatching the new macro and leaving the old one in
>> place back branches?
> 
> +1.  Breaking valid code in released branches is unfriendly.
> 

OK, that sounds reasonable. So in the backbranches we'd have both
pg_always_inline and the original pg_attriute_always_inline.

Does "backpatching the new macro" mean we'd also adjust all existing
places to use the new macro or not? I mean, we could backpatch just the
bit in c.h. I plan to adjust the places, to minimize possible conflicts
when backpatching other stuff.


regards

-- 
Tomas Vondra