From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Andrew Gierth <andrew@tao11.riddles.org.uk>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Andreas Seltenreich <seltenreich@gmx.de>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [sqlsmith] Crash in GetOldestSnapshot()
In-reply-to: 
 <CA+Tgmoadc0eTHjGYo4fMit=eq8KEngBVyHh8N82BBWsgz8aRxg@mail.gmail.com>
References: <87vazemeda.fsf@credativ.de>
 <874m6ydrna.fsf@news-spur.riddles.org.uk>
 <CAA4eK1LiRxT_iPfJ=uK13tLCtaGAQqn_YOY=6zCBqoi2mW333A@mail.gmail.com>
 <87zioqcbbv.fsf@news-spur.riddles.org.uk>
 <CA+Tgmoadc0eTHjGYo4fMit=eq8KEngBVyHh8N82BBWsgz8aRxg@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Sun, 07 Aug 2016 13:58:21 -0400"
Date: Sun, 07 Aug 2016 14:03:48 -0400
Message-ID: <3189.1470593028@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Robert Haas <robertmhaas@gmail.com> writes:
> So I think in the short term what we should do about this is just fix
> it so it doesn't crash.

Well, we clearly need to fix GetOldestSnapshot so it won't crash,
but I do not think that having RETURNING queries randomly returning
"ERROR: no known snapshots" is acceptable even for a beta release.
If we aren't prepared to do something about that before Monday,
I think we need to revert 3e2f3c2e until we do have a fix for it.

What I suggested just now in <2850.1470592623@sss.pgh.pa.us> might
be implementable with a couple hours' work, though.  Do you have a
reason to think it'd be insufficient?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers