Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.12\))
Subject: Re: Possible typo in an error message
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <3292adea-a80e-40d9-9696-69300ad4046f@proxel.se>
Date: Fri, 10 Jul 2026 10:05:33 +0200
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <318D357F-9EB7-4CAC-A4C0-CF996958461A@yesql.se>
References: <20260710.135226.779226693366680552.horikyota.ntt@gmail.com>
 <3292adea-a80e-40d9-9696-69300ad4046f@proxel.se>
To: Andreas Karlsson <andreas@proxel.se>
Archived-At: 
 <https://www.postgresql.org/message-id/318D357F-9EB7-4CAC-A4C0-CF996958461A%40yesql.se>
Precedence: bulk

> On 10 Jul 2026, at 09:31, Andreas Karlsson <andreas@proxel.se> wrote:
>=20
> On 7/10/26 06:52, Kyotaro Horiguchi wrote:
>> While translating this message, I noticed the following error text:
>> parse_jsontable.c:644:
>>> errdetail("PATH name was %s not found in nested columns list.",
>> Is this perhaps meant to be
>> PATH name %s was not found in nested columns list.
>> instead?
>=20
> Agreed, or maybe:
>=20
> "Path name %s not found in nested columns list."
>=20
> =46rom what I can see both forms are used in our error messages.

I would favor "was not found" since the JSON_TABLE support has a similar
wording for missing PLAN clauses: "PLAN clause for nested path %s was =
not
found".  Consistency within a feature is good.

>> Also, I wasn't quite sure whether the uppercase "PATH" in messages
>> such as "PATH name" has any particular significance. For the
>> translation, I ended up treating it as the ordinary word "path", =
since
>> I couldn't tell whether it was intended to refer to the SQL keyword =
or
>> just the general concept.
>=20
> Agreed, it does not look like it is a keyword so it should not be =
written in upper case.

I think it does refer to the PATH keyword in a NESTED PATH clause.  See =
below
for an example query from our regression tests:

SELECT * FROM JSON_TABLE(
       jsonb '[]', '$' AS path1
       COLUMNS (
               NESTED PATH '$' COLUMNS (
                       foo int PATH '$'
               )
       )
       PLAN DEFAULT (UNION)
) jt;

--
Daniel Gustafsson