From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Michael Paquier <michael@paquier.xyz>,
        "Jamison,
    Kirk" <k.jamison@jp.fujitsu.com>,
        "'jesper.pedersen@redhat.com'" <jesper.pedersen@redhat.com>,
        "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>,
        Bruce Momjian <bruce@momjian.us>
Subject: Re: pg_upgrade: Pass -j down to vacuumdb
In-reply-to: <201901251708.ha3sgz7dn4rm@alvherre.pgsql>
References: <201901251708.ha3sgz7dn4rm@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Fri, 25 Jan 2019 14:08:42 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31928.1548436609.1@sss.pgh.pa.us>
Date: Fri, 25 Jan 2019 12:16:49 -0500
Message-ID: <31929.1548436609@sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> So let's have it write with a $VACUUMDB_OPTS variable, which is by
> default defined as empty but with a comment suggesting that maybe the
> user wants to add the -j option.  This way, if they have to edit it,
> they only have to edit the VACUUMDB_OPTS line instead of each of the two
> vacuumdb lines.

Even better, allow the script to absorb a value from the environment,
so that it needn't be edited at all.

			regards, tom lane