From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: evtcache: EventTriggerCache vs Event Trigger Cache
In-reply-to: <5EDC969E-CAE3-4CBD-965E-3B8A1294CFA4@yesql.se>
References: <5EDC969E-CAE3-4CBD-965E-3B8A1294CFA4@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Thu, 04 May 2023 13:38:26 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3195698.1683202152.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 04 May 2023 08:09:12 -0400
Message-ID: <3195699.1683202152@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3195699.1683202152%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> When reading a memory contexts log I realized that we have this:
> LOG:  level: 2; EventTriggerCache: 8192 total in 1 blocks; 7928 free (4 =
chunks); 264 used
> LOG:  level: 3; Event Trigger Cache: 8192 total in 1 blocks; 2616 free (=
0 chunks); 5576 used

> The reason is that BuildEventTriggerCache sets up a context "EventTrigge=
rCache"
> which house a hash named "Event Trigger Cache" which in turn creates a c=
ontext
> with the table name.  I think it makes sense that these share the same n=
ame,
> but I think it would be less confusing if they also shared the same spel=
ling
> whitespace-wise.  Any reason to not rename the hash EventTriggerCache to=
 make
> the logging a tiny bit easier to read and grep?

Hmm, I'm kinda -1 on them having the same name visible in the
contexts dump --- that seems very confusing.  How about naming
the hash "EventTriggerCacheHash" or so?

			regards, tom lane