Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdDO6-0003zf-SY for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Mar 2023 16:57:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pdDO5-00045Y-CL for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Mar 2023 16:57:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdDO5-00044H-20 for pgsql-hackers@lists.postgresql.org; Fri, 17 Mar 2023 16:57:05 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pdDO2-0008Ad-L6 for pgsql-hackers@lists.postgresql.org; Fri, 17 Mar 2023 16:57:04 +0000 Received: by mail-ed1-x530.google.com with SMTP id ek18so22895808edb.6 for ; Fri, 17 Mar 2023 09:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1679072221; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VlV/CBITX87yi+S2zCCQa42EW7I4gKHPieLFLl5AG6E=; b=T2sKTDZB6c0Zuqugl1bzfAP1XoAFPVXMh/B3bOAYgst65cA9kAuCHPBWVnmkCqH9b2 Gr7cZDL3msI7VVy/OA6E4O5hkpqIBWQWfigWQ3SFbV8DY7WPg5jtrKJOD13nt+3/Piia /acz9bhAsqT4nBlEUIKcReY8rjxywiC3MSkMMq7UKS07RCacsj7Ldygpeip37+SBG39u tROgWAFYC4aobU2u4LOgzunuDTlLnfUq2GXHvaZmJwcWvBQl8fzj6kTlN3riy4aYtmQi vhdbx5Q3BbXdepctPRRMZSjh9R1o/K2SPv4VJHZlxNbLl1ptVgNAMetSBmzFIgB/Hg2a D2fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679072221; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VlV/CBITX87yi+S2zCCQa42EW7I4gKHPieLFLl5AG6E=; b=TXZZ1qUQVXrTCTP2sdQaJXgb4s2EZdXxQEx1AOfsQC52y6Y4ip7MtanSK0yeQtqIvK UII/3byPkdekMTFts2qeDnI+woDj746kWx52yp1+PXuDZwMGyMs6/TSGTdL7cOc0bSNu XTR5u9rOhHgMQgYzsf4F2V6E1/2UZGHuRzNcoTT/Lis5iUbF4esQ+ltaMkVYmzdXgSVw 4M9saUOzifaHULcgSMcPUhO6jleHx31NZHwqILShU7TmW+shXIZ2vSOKtZcpdCaJiWK6 6FuCExTOVbtcuNNtBsMi7jB263881my9FFuZq/2JdQOdpwxVcRJ6B2TGhrRP1QRcCUXP ey6w== X-Gm-Message-State: AO0yUKWZlQBB4Ct1eQifYlqITjx0edQoMxPJOYSrYBJeJqTmo5W39sl8 AkAGegzpavzR67ozXrmKqMfaCjVwmv57onETy0PW8ZM9nLe0Rp83AgUoKYkVxZyM5PE+JilEg3v MMLziG69cku2xvljaR0L2znrSN/GCsV5Hgu4N4Lmsz4AihGSZrli3RUiPdNcdT4ND1agHP6NXBN Hod0DL2kbdcY+QmjNnSLDcnBdeJh/XxqwkKO2WJpljvG1ezJNmsnlo X-Google-Smtp-Source: AK7set+gTwgS0BXYFQD3eAOEFVTzOJ3VxZDm+V55FjlfxRY8h7flArCBOZEV+epNymGz3fnaruOyiw== X-Received: by 2002:a17:906:c2cf:b0:932:66ca:faf4 with SMTP id ch15-20020a170906c2cf00b0093266cafaf4mr1681107ejb.54.1679072221239; Fri, 17 Mar 2023 09:57:01 -0700 (PDT) Received: from [10.137.0.17] (ip-86-49-228-162.bb.vodafone.cz. [86.49.228.162]) by smtp.gmail.com with ESMTPSA id w16-20020a17090649d000b00924ffcb65e7sm1177395ejv.49.2023.03.17.09.57.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Mar 2023 09:57:00 -0700 (PDT) Message-ID: <319aa3e3-e443-5a79-1c84-c4a4c0b9a8bb@enterprisedb.com> Date: Fri, 17 Mar 2023 17:56:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Add LZ4 compression in pg_dump Content-Language: en-US To: gkokolatos@pm.me Cc: Alexander Lakhin , "shiy.fnst@fujitsu.com" , Michael Paquier , Justin Pryzby , "pgsql-hackers@lists.postgresql.org" , Rachel Heaton References: <7zu6GYFi72jByVk2SEe_nd8r1DHhwA35vSntAE9sAfiMX9Lfk6bwimkwmu7GDgYaEvL27SE4qF1uK4_LHWQM4H-SXOwkMAI-GV8PKGmED_E=@pm.me> <8421f53d-c9f7-c02e-3278-9f9522a8e8f3@enterprisedb.com> <33496f7c-3449-1426-d568-63f6bca2ac1f@gmail.com> <1aBKUlb8BGVUUTkRJwEmU3ud1NyeHVCoC7bpOKAuRYlHHJ7hRiDVXYgad-wmjx1K3pykd_ctyY4Lqy9xA7JGLXOm1Eul-imdZ_7TVr5LY8U=@pm.me> <3da84c90-7e12-75ee-a582-025bc68dd098@enterprisedb.com> <5qAu7vrMV3hEodlIC82b0JICWTwEUSRoIDWlIaczNBIEVVfDH2lccxHNIQ726e4nX_Qqjc4lPc5_z9RtV28NMdVv7BNiADF4JB-FDahmlVk=@pm.me> <32ba9612-1982-4b2d-135a-5d1222987082@enterprisedb.com> From: Tomas Vondra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/17/23 16:43, gkokolatos@pm.me wrote: >> >> ... >> >> I agree it's cleaner the way you did it. >> >> I was thinking that with each compression function handling error >> internally, the callers would not need to do that. But I haven't >> realized there's logic to detect ENOSPC and so on, and we'd need to >> duplicate that in every compression func. >> > > If you agree, I can prepare a patch to improve on the error handling > aspect of the API as a separate thread, since here we are trying to > focus on correctness. > Yes, that makes sense. There are far too many patches in this thread already ... regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company