Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wi6oi-0001B8-2T for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Jul 2026 08:42:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wi6oh-00Gyse-0U for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Jul 2026 08:42:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wi6og-00GysP-0S for pgsql-hackers@lists.postgresql.org; Fri, 10 Jul 2026 08:42:39 +0000 Received: from fout-b8-smtp.messagingengine.com ([202.12.124.151]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wi6oc-00000000clX-2PFE for pgsql-hackers@postgresql.org; Fri, 10 Jul 2026 08:42:38 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id D248F1D00064; Fri, 10 Jul 2026 04:42:32 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Fri, 10 Jul 2026 04:42:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1783672952; x=1783759352; bh=ERD9Fd6y20/LNc128MBnQFBzC8FOi3X1 JrRSUhiOIWU=; b=rCzx3lDd7xB8wR2xU538GKMa4QOlQNzyXZ6ErDRoORftJRVM EN664C/xqDtIeqLuMuY5EvYA7siXYZHuirVnATNhLDaa8BU7nxqfMF+GLcYoLYO7 8ybnsrH6hC1WzM0hghspMbCzZOgoS7ofLR6k46gbCK1Yx5XEagsfbkctV+NHSa20 zgbOFtzsVCAAW8ijOgNGOw7nSfbGAo6P5lBFgrcZEjjbqZPFpkpkO0yeKoJbUTQZ O0snumG4ws/A4wAi3Hl0rOoUkxlEl16w/vxaIVDsgH6d94fQVTJziIrAuBXRIY19 4RlCY7as8Oce1nCtIkninFWUiA1kcxDQ9Ztfwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1783672952; x= 1783759352; bh=ERD9Fd6y20/LNc128MBnQFBzC8FOi3X1JrRSUhiOIWU=; b=n 2dHWoYKlUsOEeixeDhKZaaxpCenjk8vVIYZ0UfzY5/FMgQ1Ly+oFGzkAwW5OJ1wP H+Lw1I4vdh7/bED9pHGW7CHR32SPz12vq0v4VV+WaeVUNwxra7GKe4qM7oE/ZieG /n8zoqHLhLE9xEx8hg2SuAKmhVj8lucLiTOgPiCDfifuPfb14XR4jJhIhyeX//cB 5I9DsitbvIaa1MThQRApIslP638HtQwde90kunwQeoKe4XmA0ZCOsdB1LTv/5Asr o+W3rnYEglj6gZzsx+kZ2zoKXwBcd7VSVIe/n9oPa/afLnhnp7jXd4uJQaMIWw/v i+aL01bskOuQsctVbq8Og== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGxLu1kbRPsvsSOs2/WIluHR6f8/WG/Y+Pmtj2wi6MFzeYBhgmjHF4tmiKaiXE85H VuntthksWfMAhqAa8yU53xzI/fIb70QXjG5qeXS4KMtjyDBV7lU/Jr8Rc//BS/a+U2MQkB 9VAVFjkw6QQrDLXkvMq3xqyJxCJVPu1jnmiJo5EL8lfVTcF7VsjuEbpkZtW/pQTfs09ksX A8pZM55gvmBCfZSnCRvdwBTIceUr9nrrPI/lB0VrzZs6qQWbtuYwiQaXknVSjNnmqyQnzl kBXpZmGewFU1pYsbpYitBl8HIXN/XgcA/dCANlzEAvycOB3Uh3fbtaZ9h6vqQoZpZvcUcn LDFlHj7o+hzJf+gOPH2KGZFVMDIpeXIS84S8M53YzRlG3FNR06yd09lb6r5zGlI+2rjdhW VH9VKin1Zk4MKuFOn6rHBl/JdEtuW4/DI1sEf8Uz43v0FpfHx3txqjqvzmGbkXOG5REv+z qIjbixU7GJH/gBSa/+thqIKI6bKRxTQ60L3QjyEwVZq8czSg/xvjz2PeXK5kYeW417BIa4 QlUIjC7YLKWLmhD0lf6tRi84kiOTumiauef2XAhDsNpSUUbnn1dNEFJ563nVirV3xK6P2s 6lpURAYJnw08cDXl9hFBWafEhAjbayUNCChEeRAaUpUpJ8YaWQc7GbbMcbig X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Jul 2026 04:42:31 -0400 (EDT) Message-ID: <31b38752-d16f-465f-9e85-b01e6da9d36c@eisentraut.org> Date: Fri, 10 Jul 2026 10:42:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix null pointer dereference in PG19 To: Paul A Jungwirth Cc: Tom Lane , Aleksander Alekseev , PostgreSQL Development References: <84f20d0d-3bc8-4843-bd7e-21bce20f8582@eisentraut.org> <4984118e-0dc5-49a9-b279-fd0b707be8e0@eisentraut.org> <391a2845-105b-4048-a113-835c2742fea1@eisentraut.org> <1894792.1783476457@sss.pgh.pa.us> <82f35e5c-9983-4c97-8567-451bc2cb8761@eisentraut.org> Content-Language: en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 09.07.26 17:22, Paul A Jungwirth wrote: > Checking at v1 is Aleksander's original patch. Then v2 adds tests that > crash the server. v3 moves the check to rewrite time, and the tests > pass. v4 moves the check again to exec time. But v4 is a behavior > change: an UPDATE that touches zero rows no longer fails. I thought > that was weird; that's why I recommended leaving it out (in > https://www.postgresql.org/message-id/ > CA%2BrenyXPEJYOVov3XtzTp3NusGkObc9UeW-Nm78K8_nsWSnnfg%40mail.gmail.com > before I added the crashing tests). I committed patches 0001 through 0003 (squashed). I think I was mistaken about the need for an executor check (patch 0004). But we can add it on if a need appears.