Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w9ieJ-001gFu-2Q for pgsql-hackers@arkaria.postgresql.org; Mon, 06 Apr 2026 12:01:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w9ieI-008HRk-0n for pgsql-hackers@arkaria.postgresql.org; Mon, 06 Apr 2026 12:01:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w9ieH-008HRc-39 for pgsql-hackers@lists.postgresql.org; Mon, 06 Apr 2026 12:01:46 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w9ieF-00000000qbE-3vkT for pgsql-hackers@lists.postgresql.org; Mon, 06 Apr 2026 12:01:45 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 1B6925993E2 for ; Mon, 06 Apr 2026 14:01:42 +0200 (CEST) Received: from s981.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 0B16259A6C9; Mon, 06 Apr 2026 14:01:42 +0200 (CEST) Received: from localhost (unknown [172.22.191.5]) by s981.loopia.se (Postfix) with ESMTP id 082B322B17EA; Mon, 06 Apr 2026 14:01:42 +0200 (CEST) X-Virus-Scanned: amavis at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s474.loopia.se (amavis); dkim=pass (2048-bit key) header.d=proxel.se Received: from s980.loopia.se ([172.22.191.6]) by localhost (s474.loopia.se [172.22.190.14]) (amavis, port 10024) with LMTP id 3SagBT9p_dGz; Mon, 6 Apr 2026 14:01:41 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: andreas@proxel.se X-Loopia-Originating-IP: 147.28.75.140 Received: from [192.168.0.121] (customer-147-28-75-140.stosn.net [147.28.75.140]) (Authenticated sender: andreas@proxel.se) by s980.loopia.se (Postfix) with ESMTPSA id 9F85B2201555; Mon, 06 Apr 2026 14:01:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proxel.se; s=loopiadkim1707418970; t=1775476901; bh=xEMZnQhxCZ/v5Fg8QxCzaRVfRxszYEDw1UMa1XI2/dg=; h=Date:Subject:From:To:References:In-Reply-To; b=Yd/Wk4uYQD4KNNag1gwuB0VYk4IOdqiaUITC15pD3EJQ7yH2YaeFWjXperiBku3Xw 892gulp6qyUKKx2nc95zGd5BJKMksF9exiA8A0p8aYYyYUD+yJjmKAeiWK3hgbhFrv A32m1Sehy/5EJFp0/b3EH+g7jtskM8zs9hLyydudXHpdAjaZN97RqxeZgg0otf4h13 wV6dDIILp0OhxOmZA6X5oMvjDLGIGQrBb93n4cM1357PI8WkMeYRLalQSRF0wLtHmk XWXbcMh5f59hW5Nv1yFiIAK+Iu3XNR+MKq4dFWkGfujOCALb9YWQIoOYTaHYw3ixyu AeLAGmwjHhiIA== Message-ID: <31e5b65e-84f1-40c3-a7b8-6c26ae450208@proxel.se> Date: Mon, 6 Apr 2026 14:01:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: DEREF_AFTER_NULL: src/common/jsonapi.c:2529 From: Andreas Karlsson To: =?UTF-8?B?0JPQsNC70LrQuNC9INCh0LXRgNCz0LXQuQ==?= , "pgsql-hackers@lists.postgresql.org" References: <0b32e30f2fb94ae3b7f4ee15bbb072c0@rutoken.ru> <107eb23a-8ebb-42bc-99c0-ca551733e94e@proxel.se> Content-Language: en-US In-Reply-To: <107eb23a-8ebb-42bc-99c0-ca551733e94e@proxel.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 4/6/26 1:59 PM, Andreas Karlsson wrote: > If someone has a patch improving readability I would personally before > merging this since this code feels more complex than it ideally should > be but adding this noop NULL check to silence a false positive from a > static analyzer does not seem like an improvement. Whops, accidentally forgot to type some words there. That should have been: "[...] I would personally be all for merging it since this code [...]" -- Andreas Karlsson Percona