Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puYEr-0003hb-H9 for pgsql-hackers@arkaria.postgresql.org; Thu, 04 May 2023 12:39:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1puYEq-000248-Bb for pgsql-hackers@arkaria.postgresql.org; Thu, 04 May 2023 12:39:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puYEq-00023y-2e for pgsql-hackers@lists.postgresql.org; Thu, 04 May 2023 12:39:12 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1puYEn-000X9E-C1 for pgsql-hackers@postgresql.org; Thu, 04 May 2023 12:39:11 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 344Cd32A3200089; Thu, 4 May 2023 08:39:03 -0400 From: Tom Lane To: Nathan Bossart cc: Andres Freund , Xing Guo , pgsql-hackers@postgresql.org Subject: Re: PL/Python: Fix return in the middle of PG_TRY() block. In-reply-to: <20230504050108.GA2203557@nathanxps13> References: <20230113054900.b7onkvwtkrykeu3z@awork3.anarazel.de> <20230113180335.GA2160040@nathanxps13> <1864041.1673882943@sss.pgh.pa.us> <20230120010711.jpqbaelpgmuvt2vq@awork3.anarazel.de> <20230120190201.GC4106863@nathanxps13> <20230503202116.GA2110623@nathanxps13> <3012766.1683146012@sss.pgh.pa.us> <20230503205838.GA2112379@nathanxps13> <20230504045413.GA2202617@nathanxps13> <20230504050108.GA2203557@nathanxps13> Comments: In-reply-to Nathan Bossart message dated "Wed, 03 May 2023 22:01:08 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3200087.1683203943.1@sss.pgh.pa.us> Date: Thu, 04 May 2023 08:39:03 -0400 Message-ID: <3200088.1683203943@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Nathan Bossart writes: > Gah, right after I sent that, I realized we can remove one more volatile > marker. Sorry for the noise. Hmm, I'm not sure why PLy_trigger_build_args's pltargs needs to gain a "volatile" here? LGTM otherwise. regards, tom lane