From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Andres Freund <andres@anarazel.de>, Amit Kapila <amit.kapila16@gmail.com>,
        Michael Paquier <michael@paquier.xyz>,
        Julien Rouhaud <rjuju123@gmail.com>,
        Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Missing errcode() in ereport
In-reply-to: <28622.1585114797@sss.pgh.pa.us>
References: <32174.1584454158@sss.pgh.pa.us>
 <20200319175902.vjib2tslosw65iyr@alap3.anarazel.de>
 <5063.1584641224@sss.pgh.pa.us>
 <20200319230446.lxjybufdcgwaqkhj@alap3.anarazel.de>
 <5995.1584660775@sss.pgh.pa.us>
 <20200320015908.ajxneh4jx6avqegv@alap3.anarazel.de>
 <9966.1584671550@sss.pgh.pa.us>
 <20200320045637.n3xo6gcmbqcg42tq@alap3.anarazel.de>
 <15922.1584715221@sss.pgh.pa.us> <31649.1584998689@sss.pgh.pa.us>
 <20200324193834.dojfetuxqupii577@alap3.anarazel.de>
 <6677.1585081791@sss.pgh.pa.us>
 <CA+hUKGJ35GzhsLgKDFQ7MQN6piiZLLZ+MTevvYxbw=_GHpsP=A@mail.gmail.com>
 <28622.1585114797@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Wed, 25 Mar 2020 01:39:57 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32023.1585153102.1@sss.pgh.pa.us>
Date: Wed, 25 Mar 2020 12:18:22 -0400
Message-ID: <32024.1585153102@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Thomas Munro <thomas.munro@gmail.com> writes:
>> I think this caused anole to say:
>> "reloptions.c", line 1362: error #2042: operand types are incompatible
>> ("void" and "int")
>> errdetail_internal("%s", _(optenum->detailmsg)) : 0));

> Yeah, I was just looking at that :-(

> We could revert the change to have these functions return void,
> or we could run around and change the places with this usage
> pattern to use "(void) 0" instead of just "0".  The latter would
> be somewhat painful if only minority compilers warn, though.
> Also, I don't think that having to change ereport usage was part
> of the agreed-to plan here ... so I'm leaning to the former.

Done that way.

			regards, tom lane