Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jCpya-0002Np-Hp for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Mar 2020 19:28:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jCpyY-0008Hr-TD for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Mar 2020 19:28:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jCpyY-0008Hk-HH for pgsql-hackers@lists.postgresql.org; Fri, 13 Mar 2020 19:28:06 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jCpyR-0003v8-T9 for pgsql-hackers@lists.postgresql.org; Fri, 13 Mar 2020 19:28:05 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 02DJRqtb032056; Fri, 13 Mar 2020 15:27:53 -0400 From: Tom Lane To: Alvaro Herrera cc: James Coleman , Tomas Vondra , Michael Paquier , Rafia Sabih , Peter Geoghegan , Simon Riggs , Shaun Thomas , Dmitry Dolgov <9erthalion6@gmail.com>, Alexander Korotkov , PostgreSQL Developers Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort) In-reply-to: <20200313190931.GA11508@alvherre.pgsql> References: <20200313190931.GA11508@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Fri, 13 Mar 2020 16:09:31 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32054.1584127672.1@sss.pgh.pa.us> Date: Fri, 13 Mar 2020 15:27:52 -0400 Message-ID: <32055.1584127672@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Alvaro Herrera writes: > ... You can specify a filelist to pgindent, also. What I do is super > low-tech: do a "git diff origin/master", copy the filelist, and then > ^V^E to paste that list into a command line to run pgindent (editing to > remove the change histogram and irrelevant files). I should automate > this ... Yeah. I tend to keep copies of the files I'm specifically hacking on in a separate work directory, and then I re-indent just that directory. But that's far from ideal as well. I wonder if it'd be worth teaching pgindent to have some option to indent only files that are already modified according to git? regards, tom lane