From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: John Naylor <johncnaylorls@gmail.com>, Ants Aasma <ants@cybertec.at>,
        pgsql-hackers@postgresql.org
Subject: Re: add AVX2 support to simd.h
In-reply-to: <20240327013616.GA3940109@nathanxps13>
References: <20240320143116.GA1313857@nathanxps13>
 <20240320195513.GA1618413@nathanxps13>
 <CANWCAZYfUv3iN2Vx--tmQP9WU6xwfU8d=gA7LoFXOYP9-wo8Hg@mail.gmail.com>
 <20240321170944.GA1767527@nathanxps13>
 <CANWCAZb7TGEk6ib12Rr6pbGMy9pqofT0dS=8Dkm+=MwJQZAEww@mail.gmail.com>
 <20240325152121.GB2662364@nathanxps13> <20240325213754.GA3094030@nathanxps13>
 <20240326190904.GA3700674@nathanxps13> <3189995.1711495704@sss.pgh.pa.us>
 <20240326235554.GA3766883@nathanxps13> <20240327013616.GA3940109@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Tue, 26 Mar 2024 20:36:16 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3206055.1711504137.1@sss.pgh.pa.us>
Date: Tue, 26 Mar 2024 21:48:57 -0400
Message-ID: <3206056.1711504137@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3206056.1711504137%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Tue, Mar 26, 2024 at 06:55:54PM -0500, Nathan Bossart wrote:
>> On Tue, Mar 26, 2024 at 07:28:24PM -0400, Tom Lane wrote:
>>> A significant fraction of the buildfarm is issuing warnings about
>>> this.

> Done.  I'll keep an eye on the farm.

Thanks.

> I just did the minimal fix for now, i.e., I moved the new label into the
> SIMD section of the function.  I think it would be better stylistically to
> move the one-by-one logic to an inline helper function, but I didn't do
> that just in case it might negatively impact performance.  I'll look into
> this and will follow up with another patch if it looks good.

Sounds like a plan.

			regards, tom lane