From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Stephen Frost <sfrost@snowman.net>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Ian Barwick <ian.barwick@2ndquadrant.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
In-reply-to: 
 <CA+TgmobRpgiqCZ_FMUeDW4RM1W+RzT4HA2xSQy=QMcfv=X47jw@mail.gmail.com>
References: <15032.1561403529@sss.pgh.pa.us>
 <20190624192014.GB2480@tamriel.snowman.net>
 <56aff4f3-dec8-f462-7feb-0938411b04a6@2ndquadrant.com>
 <CAA4eK1+JMm=tvx720y6jhD8pdzt=HdS1-TwQwkARib2pwK8EvQ@mail.gmail.com>
 <20190802222254.qsvqjtkwte464lu3@development>
 <31697.1564784856@sss.pgh.pa.us>
 <CAOuzzgqNyQM_z0biEEBVBK9WcaLmbCyWrd5xTdf-Oxb_9pntLA@mail.gmail.com>
 <20190802230011.dqokdhjptykopxxc@development>
 <20190805142139.GW29202@tamriel.snowman.net>
 <CA+Tgmoatso2sR=_LSSR443YjAfvQ48zpbYYVYQUHVMSoxsrJ9g@mail.gmail.com>
 <20190805172935.GK29202@tamriel.snowman.net>
 <CA+TgmoZmSQCta7eN_Y2+U4LthMxcutGB+YXs+0-i6ND2JY0TRA@mail.gmail.com>
 <30179.1565029753@sss.pgh.pa.us>
 <CA+TgmoYEQyLE8Mtgko9-WSVWm=hLNGi3FO4xNLTrLpwi2GgPHw@mail.gmail.com>
 <30823.1565030571@sss.pgh.pa.us>
 <CA+TgmobRpgiqCZ_FMUeDW4RM1W+RzT4HA2xSQy=QMcfv=X47jw@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Mon, 05 Aug 2019 14:43:51 -0400"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <32050.1565031993.0@sss.pgh.pa.us>
Date: Mon, 05 Aug 2019 15:07:33 -0400
Message-ID: <32103.1565032053@sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32050.1565031993.1@sss.pgh.pa.us>

Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Aug 5, 2019 at 2:42 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I don't think we need to go on about it at great length, but it seems
>> to me that it'd be reasonable to point out that (a) you'd be well
>> advised not to touch the file while the postmaster is up, and (b)
>> last setting wins.  Those things are equally true of postgresql.conf
>> of course, but I don't recall whether they're already documented.

> OK, fair enough.

Concretely, how about the attached?

(Digging around in config.sgml, I found that last-one-wins is stated,
but only in the context of one include file overriding another.
That's not *directly* a statement about what happens within a single
file, and it's in a different subsection anyway, so repeating the
info in 19.1.2 doesn't seem unreasonable.)

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-diff;
	name="doc-handling-of-config-file-dup-entries.patch";
	charset="us-ascii"
Content-ID: <32050.1565031993.2@sss.pgh.pa.us>
Content-Description: doc-handling-of-config-file-dup-entries.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index cdc30fa..f5986b2 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -153,6 +153,8 @@ shared_buffers =3D 128MB
      identifiers or numbers must be single-quoted.  To embed a single
      quote in a parameter value, write either two quotes (preferred)
      or backslash-quote.
+     If the file contains multiple entries for the same parameter,
+     all but the last one are ignored.
     </para>
 =

     <para>
@@ -185,18 +187,27 @@ shared_buffers =3D 128MB
      In addition to <filename>postgresql.conf</filename>,
      a <productname>PostgreSQL</productname> data directory contains a fi=
le
      <filename>postgresql.auto.conf</filename><indexterm><primary>postgre=
sql.auto.conf</primary></indexterm>,
-     which has the same format as <filename>postgresql.conf</filename> bu=
t should
-     never be edited manually.  This file holds settings provided through
-     the <xref linkend=3D"sql-altersystem"/> command.  This file is autom=
atically
-     read whenever <filename>postgresql.conf</filename> is, and its setti=
ngs take
-     effect in the same way.  Settings in <filename>postgresql.auto.conf<=
/filename>
-     override those in <filename>postgresql.conf</filename>.
+     which has the same format as <filename>postgresql.conf</filename> bu=
t
+     is intended to be edited automatically not manually.  This file hold=
s
+     settings provided through the <xref linkend=3D"sql-altersystem"/> co=
mmand.
+     This file is read whenever <filename>postgresql.conf</filename> is,
+     and its settings take effect in the same way.  Settings
+     in <filename>postgresql.auto.conf</filename> override those
+     in <filename>postgresql.conf</filename>.
+    </para>
+
+    <para>
+     External tools might also
+     modify <filename>postgresql.auto.conf</filename>, typically by appen=
ding
+     new settings to the end.  It is not recommended to do this while the
+     server is running, since a concurrent <command>ALTER SYSTEM</command=
>
+     command could overwrite such changes.
     </para>
 =

     <para>
      The system view
      <link linkend=3D"view-pg-file-settings"><structname>pg_file_settings=
</structname></link>
-     can be helpful for pre-testing changes to the configuration file, or=
 for
+     can be helpful for pre-testing changes to the configuration files, o=
r for
      diagnosing problems if a <systemitem>SIGHUP</systemitem> signal did =
not have the
      desired effects.
     </para>

------- =_aaaaaaaaaa0--