From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Pavan Deolasee <pavan.deolasee@gmail.com>,
        Jaime Casanova <jaime.casanova@2ndquadrant.com>,
        Haribabu Kommi <kommi.haribabu@gmail.com>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Patch: Write Amplification Reduction Method (WARM)
In-reply-to: <20170131215538.5c65rexachourokl@alap3.anarazel.de>
References: 
 <CABOikdNU0qhKE-65x59qaj2kL-Jpq73Ri95ZODAvxxhsEBN9LQ@mail.gmail.com>
 <20170131171001.wg7bc4pimfu6in6t@alvherre.pgsql>
 <20170131215538.5c65rexachourokl@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Tue, 31 Jan 2017 13:55:38 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32114.1485901288.1@sss.pgh.pa.us>
Date: Tue, 31 Jan 2017 17:21:28 -0500
Message-ID: <32115.1485901288@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Andres Freund <andres@anarazel.de> writes:
> Hm, sorry for missing this earlier.  I think CatalogUpdateIndexes() is
> fairly widely used in extensions - it seems like a pretty harsh change
> to not leave some backward compatibility layer in place.

If an extension is doing that, it is probably constructing tuples to put
into the catalog, which means it'd be equally (and much more quietly)
broken by any change to the catalog's schema.  We've never considered
such an argument as a reason not to change catalog schemas, though.

In short, I've got mighty little sympathy for that argument.

(I'm a little more concerned by Alvaro's apparent position that WARM
is a done deal; I didn't think so.  This particular change seems like
good cleanup anyhow, however.)

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers