Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jYsLV-0005W2-Pm
	for pgsql-hackers@arkaria.postgresql.org; Wed, 13 May 2020 14:26:53 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jYsLU-00057C-Kg
	for pgsql-hackers@arkaria.postgresql.org; Wed, 13 May 2020 14:26:52 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jYsLU-000575-Dv
	for pgsql-hackers@lists.postgresql.org; Wed, 13 May 2020 14:26:52 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jYsLQ-00071r-Vn
	for pgsql-hackers@postgresql.org; Wed, 13 May 2020 14:26:51 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 04DEQdLR032136;
	Wed, 13 May 2020 10:26:40 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
        "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: SLRU statistics
In-reply-to: <b407746a-4fb6-7128-9391-c3765eb44718@oss.nttdata.com>
References: <20200402004136.wodwftan45mcwggm@development>
 <f02fd0ec-a240-b5bf-9992-5faf582738f1@oss.nttdata.com>
 <20200430181901.24tlriahmafi4sfn@development>
 <0e1c8904-13be-ab70-0096-54f0b30e43ba@oss.nttdata.com>
 <20200502000818.nn4kpewiput42bnb@development>
 <49b8ad17-f6d9-a086-a952-ff1fec3ac1b3@oss.nttdata.com>
 <20200502105500.hwhba3d6s3hlrqf6@development>
 <20200502165905.brfxv6dk5vjdbgti@development>
 <976bbb73-a112-de3c-c488-b34b64609793@oss.nttdata.com>
 <b8784fe6-1401-ab35-aa14-d57b5bb8e312@oss.nttdata.com>
 <20200513082159.myflgcs5fnhnujbk@development>
 <b407746a-4fb6-7128-9391-c3765eb44718@oss.nttdata.com>
Comments: In-reply-to Fujii Masao <masao.fujii@oss.nttdata.com>
	message dated "Wed, 13 May 2020 22:22:12 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32134.1589379999.1@sss.pgh.pa.us>
Date: Wed, 13 May 2020 10:26:39 -0400
Message-ID: <32135.1589379999@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> On 2020/05/13 17:21, Tomas Vondra wrote:
>> On Wed, May 13, 2020 at 04:10:30PM +0900, Fujii Masao wrote:
>>> Also I found another minor issue; SLRUStats has not been initialized to 0
>>> and which could update the counters unexpectedly. Attached patch fixes
>>> this issue.

> Pushed both. Thanks!

Why is that necessary?  A static variable is defined by C to start off
as zeroes.

			regards, tom lane