From: Tom Lane <tgl@sss.pgh.pa.us>
To: Piotr Stefaniak <postgres@piotr-stefaniak.me>
cc: Thomas Munro <thomas.munro@gmail.com>,
        Pg Hackers <pgsql-hackers@postgresql.org>,
        Michael Paquier <michael@paquier.xyz>
Subject: Re: Emacs vs pg_indent's weird indentation for function declarations
In-reply-to: 
 <DB8PR03MB59315C886E551B2D4483099FF2050@DB8PR03MB5931.eurprd03.prod.outlook.com>
References: 
 <CAEepm=0P3FeTXRcU5B2W3jv3PgRVZ-kGUXLGfd42FFhUROO3ug@mail.gmail.com>
 <7659.1548653310@sss.pgh.pa.us> <20190128070842.GF15401@paquier.xyz>
 <CAEepm=0UtAPN2RChs7=pOqHm2uvbU6Px7vfyvt8_-eiP7=ozUg@mail.gmail.com>
 <CA+hUKGKCvoUsU_HpW+hg8WNDUFjQEgQvVi9AwYdsqgJfV8TzxQ@mail.gmail.com>
 <14259.1557895390@sss.pgh.pa.us> <9170.1557955021@sss.pgh.pa.us>
 <CA+hUKGKb9n8xgWW3uEiA3Txvb9Er-FRX-wAAiiWdAjD7-nN44Q@mail.gmail.com>
 <17265.1557955842@sss.pgh.pa.us> <16886.1558104483@sss.pgh.pa.us>
 <DB8PR03MB59315C886E551B2D4483099FF2050@DB8PR03MB5931.eurprd03.prod.outlook.com>
Comments: In-reply-to Piotr Stefaniak <postgres@piotr-stefaniak.me>
	message dated "Sun, 19 May 2019 17:25:05 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32164.1558286841.1@sss.pgh.pa.us>
Date: Sun, 19 May 2019 13:27:21 -0400
Message-ID: <32165.1558286841@sss.pgh.pa.us>
Precedence: bulk

Piotr Stefaniak <postgres@piotr-stefaniak.me> writes:
> On 17/05/2019 16.48, Tom Lane wrote:
>> It doesn't really seem practical to me to make the lookahead function
>> smart enough to tell the difference between attributes and K&R-style
>> parameter declarations.  What I'm thinking of doing to have an
>> upstreamable patch is to invent a new switch, perhaps '-kr'/'-nkr',
>> to indicate whether the user is more worried about K&R function
>> declarations than she is about function attributes. 

> I think it's safe to assume that upstream can drop support for K&R-style 
> parameters altogether.

Cool.  I already created the switch, but maybe we could have it
default to -nkr?

			regards, tom lane