Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1goF2G-0002AD-K2
	for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Jan 2019 22:05:44 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1goF2F-0007YT-CV
	for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Jan 2019 22:05:43 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1goF2E-0007Xi-RJ
	for pgsql-hackers@lists.postgresql.org; Mon, 28 Jan 2019 22:05:42 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1goF2C-0007YL-MK
	for pgsql-hackers@postgresql.org; Mon, 28 Jan 2019 22:05:41 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x0SM5WWr032185;
	Mon, 28 Jan 2019 17:05:33 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Robert Haas <robertmhaas@gmail.com>, Andreas Karlsson <andreas@proxel.se>,
        Andres Freund <andres@anarazel.de>,
        Thomas Munro <thomas.munro@enterprisedb.com>,
        Andrew Gierth <andrew@tao11.riddles.org.uk>,
        David Fetter <david@fetter.org>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Early WIP/PoC for inlining CTEs
In-reply-to: <c16909ed-0789-5199-f315-5433d83a0026@2ndquadrant.com>
References: <dccb37dd-2f52-dbd7-a4c4-72a5853f4838@proxel.se>
 <e02af96a-3e25-5de4-09a4-a7ebf3452184@proxel.se>
 <8810.1542402910@sss.pgh.pa.us>
 <d4daf011-01cf-6bf9-3f15-85ae1572e909@proxel.se>
 <87r2dxrw1z.fsf@news-spur.riddles.org.uk>
 <d0619160-10af-dcc9-4e7d-57845b92570c@proxel.se>
 <CAEepm=2x3kJ5AdkKmEf_ODAZm7+e=7DW1u-+ZwfncWvd8xDaiA@mail.gmail.com>
 <CA+Tgmob=Dpje+oGCYgJCoUok=iPQarGjPqRLYS1qKzChkFfKcA@mail.gmail.com>
 <20190111181934.g5qig23o7rxubnjt@alap3.anarazel.de>
 <CAEepm=2n8hChj548H0R5g5JAx3cokpZwTqRzYhN2oVGqBONwOA@mail.gmail.com>
 <20190111190403.77ye7m5mxypxsf4l@alap3.anarazel.de>
 <CA+TgmobVMPX1wJxPaRQ=FZBzp-AQ=JWK=bzxztqwj=MsOsrnrA@mail.gmail.com>
 <00818be9-2f63-f584-efcd-d97ee0662905@proxel.se>
 <CA+TgmoapASa3RQi=DuSikPoPF4363czSD8KxbOxsfW5XmO3WpQ@mail.gmail.com>
 <5715d93e-6ebc-be17-c2c3-56a873100a38@proxel.se>
 <29576.1548084476@sss.pgh.pa.us>
 <CA+TgmoYZYj8eLdV9AcROtmPW4AJA7ANh3xQh7BcafaPfCnmv+g@mail.gmail.com>
 <12408.1548707732@sss.pgh.pa.us> <c16909ed-0789-5199-f315-!
 5433d83a0026@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Mon, 28 Jan 2019 22:54:11 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32183.1548713132.1@sss.pgh.pa.us>
Date: Mon, 28 Jan 2019 17:05:32 -0500
Message-ID: <32184.1548713132@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 28/01/2019 21:35, Tom Lane wrote:
>> Conceivably we could make it work without the parens:
>> ...

> Or put it at the end?
>     WITH ctename AS ( query ) MATERIALIZED

Yeah, I thought about that too, but it doesn't seem like an improvement.
If the query is very long (which isn't unlikely) I think people would
prefer to see the option(s) up front.

			regards, tom lane