Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmP5H-0005GJ-HO for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Mar 2017 18:16:11 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cmP5H-0001gD-3z for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Mar 2017 18:16:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cmP5F-0001bx-NZ for pgsql-hackers@postgresql.org; Fri, 10 Mar 2017 18:16:09 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cmP5D-0003pM-Rr for pgsql-hackers@postgresql.org; Fri, 10 Mar 2017 18:16:09 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v2AIG5sP032203; Fri, 10 Mar 2017 13:16:05 -0500 From: Tom Lane To: Robert Haas cc: "pgsql-hackers@postgresql.org" Subject: Re: Bizarre choice of case for RELKIND_PARTITIONED_TABLE In-reply-to: <8913.1488927818@sss.pgh.pa.us> References: <27899.1488909319@sss.pgh.pa.us> <8913.1488927818@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Tue, 07 Mar 2017 18:03:38 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32201.1489169765.1@sss.pgh.pa.us> Date: Fri, 10 Mar 2017 13:16:05 -0500 Message-ID: <32202.1489169765@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org I wrote: > Robert Haas writes: >> On Tue, Mar 7, 2017 at 12:55 PM, Tom Lane wrote: >>> Is there a good reason why RELKIND_PARTITIONED_TABLE is 'P' not 'p'? >> I can't muster a lot of outrage about this one way or another. One >> possible advantage of 'P' is that there are fewer places where 'P' is >> mentioned in the source code than 'p'. > Hm, one would hope that the vast majority of code references are neither > of those, but rather "RELKIND_PARTITIONED_TABLE". information_schema.sql > and system_views.sql will need to be gone over carefully, certainly, but > we shouldn't be hard-coding this anywhere that there's a reasonable > alternative. Pushed. I was a bit disappointed to find that make check-world passed just fine without having updated either information_schema.sql or system_views.sql. Evidently our test coverage for these views leaves something to be desired. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers