From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: pgsql-hackers@lists.postgresql.org,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
In-reply-to: <YO1GcUp9IPVU9wuJ@paquier.xyz>
References: <3185430.1626133592@sss.pgh.pa.us> <YOzy2rlluWYYoUvW@paquier.xyz>
 <3198753.1626150306@sss.pgh.pa.us> <YO1GcUp9IPVU9wuJ@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 13 Jul 2021 16:53:21 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3226451.1626184689.1@sss.pgh.pa.us>
Date: Tue, 13 Jul 2021 09:58:09 -0400
Message-ID: <3226452.1626184689@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3226452.1626184689%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Jul 13, 2021 at 12:25:06AM -0400, Tom Lane wrote:
>> That's easy enough in v13 and up, which have 8f4fb4c64 so that
>> Solution.pm looks like this.  We could make it consistent in older
>> branches by manually hacking pg_config.h.win32 ... but I'm wondering
>> if the smarter plan wouldn't be to back-patch 8f4fb4c64.

> ... I am not sure that the potential maintenance gain is worth
> poking at the stable branches, to be honest.

Fair enough.  I wasn't very eager to do the legwork on that, either,
given that the issue is (so far) only cosmetic.

			regards, tom lane