From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
cc: pgsql-hackers@postgresql.org
Subject: Re: "repliation" as database name
In-reply-to: <20181221.155614.267264951.horiguchi.kyotaro@lab.ntt.co.jp>
References: <20181218.184825.02619975.horiguchi.kyotaro@lab.ntt.co.jp>
 <20181221.155614.267264951.horiguchi.kyotaro@lab.ntt.co.jp>
Comments: In-reply-to Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
	message dated "Fri, 21 Dec 2018 15:56:14 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32288.1545847172.1@sss.pgh.pa.us>
Date: Wed, 26 Dec 2018 12:59:32 -0500
Message-ID: <32289.1545847172@sss.pgh.pa.us>
Precedence: bulk

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> I found that in the documentation thanks to a notification
> off-list. And after some reconfirmation, what I want to fix is
> only a few lines of comment in pg_hba.conf.sample.

> -# database name, or a comma-separated list thereof. The "all"
> -# keyword does not match "replication". Access to replication
> -# must be enabled in a separate record (see example below).
> +# database name, or a comma-separated list thereof. The "all" keyword
> +# matches all databases. The "replication" keyword matches a physical
> +# replication connection request and it must be enabled in a separate
> +# record (see example below)

Hm, I agree that the para doesn't read very well now, but I think this
could be improved further.  How about something like

# DATABASE can be "all", "sameuser", "samerole", "replication", a
# database name, or a comma-separated list thereof.  The "replication"
# keyword matches replication connection requests (see example below).
# The "all" keyword matches all database names, but not replication
# connections.

			regards, tom lane