From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Kuzmenkov <akuzmenkov@timescale.com>
cc: pgsql-hackers@postgresql.org
Subject: Re: Correct SQLSTATE for ENOMEM in file access
In-reply-to: <CALzhyqzgQph0BY8-hFRRGdHhF8CoqmmDHW9S=hMZ-HMzLxRqDQ@mail.gmail.com>
References: <CALzhyqzgQph0BY8-hFRRGdHhF8CoqmmDHW9S=hMZ-HMzLxRqDQ@mail.gmail.com>
Comments: In-reply-to Alexander Kuzmenkov <akuzmenkov@timescale.com>
	message dated "Fri, 02 Feb 2024 20:02:37 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3229196.1706901133.1@sss.pgh.pa.us>
Date: Fri, 02 Feb 2024 14:12:13 -0500
Message-ID: <3229197.1706901133@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3229197.1706901133%40sss.pgh.pa.us>
Precedence: bulk

Alexander Kuzmenkov <akuzmenkov@timescale.com> writes:
> Looking through the logs of some server that were experiencing out of
> memory errors, I noticed that errcode_for_file_access() reports
> ERRCODE_INTERNAL_ERROR for ENOMEM, while the correct SQLSTATE for this
> should probably be ERRCODE_OUT_OF_MEMORY. Attached is a small patch to
> fix this.

Hmm, do you think this is actually reachable?  AFAIK we should only be
calling errcode_for_file_access() after functions that are unlikely to
report ENOMEM.

			regards, tom lane