From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?UTF-8?B?SXZhbiBQYW5jaGVua28=?= <wao@mail.ru>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: =?UTF-8?B?anNvbmJfcGxwZXJsIGJ1Zw==?=
In-reply-to: <1564783533.324795401@f193.i.mail.ru>
References: <1564783533.324795401@f193.i.mail.ru>
Comments: In-reply-to =?UTF-8?B?SXZhbiBQYW5jaGVua28=?= <wao@mail.ru>
	message dated "Sat, 03 Aug 2019 01:05:33 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32323.1564785590.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 02 Aug 2019 18:39:50 -0400
Message-ID: <32324.1564785590@sss.pgh.pa.us>
Precedence: bulk

=3D?UTF-8?B?SXZhbiBQYW5jaGVua28=3D?=3D <wao@mail.ru> writes:
> I have found a bug in jsonb_plperl extension. A possible fix is proposed=
 below.
> ...
> +				/* SVt_PV without POK flag is also NULL */
> +				if(SvTYPE(in) =3D=3D SVt_PV) =


Ugh.  Doesn't Perl provide some saner way to determine the type of a SV?

The core code seems to think that SvOK() is a sufficient test for an
undef.  Should we be doing that before the switch, perhaps?

(My underlying concern here is mostly about whether we have other
similar bugs.  There are a lot of places checking SvTYPE.)

			regards, tom lane