public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Robert Haas <[email protected]>
Cc: Ed Behn <[email protected]>
Cc: [email protected]
Subject: Re: access numeric data in module
Date: Mon, 09 Sep 2024 14:02:52 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoZjAGx+6qTpbiwRbufo9p9fF36UAirVdEArZq2Wg+8Mvg@mail.gmail.com>
References: <CAJBL5DP2emt+WPeCo+YY_ogsGt90-_kRU3weS5YJLQTfNZr72Q@mail.gmail.com>
	<[email protected]>
	<CA+TgmobyHf6A0ULnQZGKOm9c4_6XD9+zxLiORamSLr8UmXxTZA@mail.gmail.com>
	<[email protected]>
	<CA+TgmoZjAGx+6qTpbiwRbufo9p9fF36UAirVdEArZq2Wg+8Mvg@mail.gmail.com>

Robert Haas <[email protected]> writes:
> On Mon, Sep 9, 2024 at 1:25 PM Tom Lane <[email protected]> wrote:
>> IMO it'd be a lot better if numeric.c exposed whatever functionality
>> Ed feels is missing, while keeping the contents of a numeric opaque.

> We could certainly expose a bunch of functions, but I think that would
> actually be a bigger maintenance burden for us than just exposing some
> of the details that are currently private to numeric.c.

This whole argument is contingent on details that haven't been
provided, namely exactly what it is that Ed wants to do that he can't
do today.  I think we should investigate that before deciding that
publishing previously-private detail is the best solution.

> Also, this seems to me to be holding the numeric data type to a
> different standard than other things.

By that argument, we should move every declaration in every .c file
into c.h and be done.  I'd personally be happier if we had *not*
exposed the other data structure details you mention, but that
ship has sailed.

If we do do what you're advocating, I'd at least insist that the
declarations go into a new file numeric_internal.h, so that it's
clear to all concerned that they're playing with fire if they
depend on that stuff.

			regards, tom lane

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: access numeric data in module
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox