Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5xn8-0007q1-8w for pgsql-hackers@arkaria.postgresql.org; Wed, 03 May 2017 17:10:18 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d5xn7-0003lA-Re for pgsql-hackers@arkaria.postgresql.org; Wed, 03 May 2017 17:10:17 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d5xlc-0000vu-IU for pgsql-hackers@postgreSQL.org; Wed, 03 May 2017 17:08:44 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d5xla-0002MR-2R for pgsql-hackers@postgreSQL.org; Wed, 03 May 2017 17:08:43 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v43H8e1Y032387; Wed, 3 May 2017 13:08:40 -0400 From: Tom Lane To: Kevin Grittner cc: pgsql-hackers@postgreSQL.org Subject: How huge does mvtest_huge need to be? MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32385.1493831320.1@sss.pgh.pa.us> Date: Wed, 03 May 2017 13:08:40 -0400 Message-ID: <32386.1493831320@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Continuing to investigate possible speedups of the regression tests, I noticed that some of the slower individual statements are those dealing with mvtest_huge and mvtest_hugeview in matview.sql. Cutting the size of mvtest_huge from 100K rows to 10K rows is enough to halve the overall runtime of matview.sql, at least on the relatively slow buildfarm animal I was checking this on. I was going to propose doing that, but then looking at commit b69ec7cc9 which introduced these tables, I began to wonder why they're large at all. Even a one-row matview would have been enough to test for the bug that that commit fixed. So ... is there a good reason to be using a large table here, and if so what is it, and how big does the table really need to be to provide useful test coverage? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers