Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1os4UC-0005zQ-2R for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Nov 2022 15:56:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1os4UA-0006fX-V7 for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Nov 2022 15:56:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1os4UA-0006cw-LS for pgsql-hackers@lists.postgresql.org; Mon, 07 Nov 2022 15:56:30 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1os4U8-0002dy-C1 for pgsql-hackers@postgresql.org; Mon, 07 Nov 2022 15:56:29 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2A7FuGSw3239883; Mon, 7 Nov 2022 10:56:16 -0500 From: Tom Lane To: Andres Freund cc: John Naylor , Thomas Munro , "Shinoda, Noriyoshi (PN Japan FSIP)" , Jacob Champion , Masahiko Sawada , Fujii Masao , Justin Pryzby , PostgreSQL-development , Julien Rouhaud , Kyotaro Horiguchi Subject: Re: Improve logging when using Huge Pages In-reply-to: <20221107151458.6puzamerxti2y5in@awork3.anarazel.de> References: <20211022023815.GI741@telsasoft.com> <20211028220534.GB31568@telsasoft.com> <20221107151458.6puzamerxti2y5in@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Mon, 07 Nov 2022 07:14:58 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3239881.1667836576.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Mon, 07 Nov 2022 10:56:16 -0500 Message-ID: <3239882.1667836576@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-11-06 14:04:29 +0700, John Naylor wrote: >> I think the best thing to do is change huge_pages=3D'on' to log a WARNI= NG and >> fallback to regular pages if the mapping fails. > I am strongly opposed to making 'on' fall back to not using huge pages. = That's > what 'try' is for. Agreed --- changing "on" to be exactly like "try" isn't an improvement. If you want "try" semantics, choose "try". regards, tom lane