From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: cataloguing NOT NULL constraints
In-reply-to: <20230407211950.aojbdirwdrxjeyzb@awork3.anarazel.de>
References: <20230407211000.d2iaklm76djy26nm@awork3.anarazel.de>
 <20230407211155.qrc2bqgyogvrfkzo@alvherre.pgsql>
 <20230407211950.aojbdirwdrxjeyzb@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Fri, 07 Apr 2023 14:19:50 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3242329.1680903993.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 07 Apr 2023 17:46:33 -0400
Message-ID: <3242330.1680903993@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3242330.1680903993%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2023-04-07 23:11:55 +0200, Alvaro Herrera wrote:
>> Ah, cool, no worries.  I would have stopped indeed, but I had to stay
>> around in case of any test failures.

> Looks like there's work for you if you want ;)
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Drhinoceros&dt=3D=
2023-04-07%2018%3A52%3A13

> But IMO fixing sepgsql can easily wait till tomorrow.

I can deal with that one -- it's a bit annoying to work with sepgsql
if you're not on a Red Hat platform.

After quickly eyeing the diffs, I'm just going to take the new output
as good.  I'm not surprised that there are additional output messages
given the additional catalog entries this made.  I *am* a bit surprised
that some messages seem to have disappeared --- are there places where
this resulted in fewer catalog accesses than before?  Nonetheless,
there's no good reason to assume this test is exposing any bugs.

			regards, tom lane