From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: cataloguing NOT NULL constraints
In-reply-to: <20230407222326.54ng3j4phv3es3s3@awork3.anarazel.de>
References: <20230407211000.d2iaklm76djy26nm@awork3.anarazel.de>
 <20230407211155.qrc2bqgyogvrfkzo@alvherre.pgsql>
 <20230407211950.aojbdirwdrxjeyzb@awork3.anarazel.de>
 <3242330.1680903993@sss.pgh.pa.us>
 <20230407222326.54ng3j4phv3es3s3@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Fri, 07 Apr 2023 15:23:26 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3248612.1680906388.1@sss.pgh.pa.us>
Date: Fri, 07 Apr 2023 18:26:28 -0400
Message-ID: <3248613.1680906388@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3248613.1680906388%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2023-04-07 17:46:33 -0400, Tom Lane wrote:
>> After quickly eyeing the diffs, I'm just going to take the new output
>> as good.  I'm not surprised that there are additional output messages
>> given the additional catalog entries this made.  I *am* a bit surprised
>> that some messages seem to have disappeared --- are there places where
>> this resulted in fewer catalog accesses than before?  Nonetheless,
>> there's no good reason to assume this test is exposing any bugs.

> I wonder if the issue is that the new paths miss a hook invocation.

Perhaps.  I'm content to silence the buildfarm for today; we can
investigate more closely later.

			regards, tom lane