Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5Dah-0005xk-6u for pgsql-hackers@arkaria.postgresql.org; Sat, 16 Mar 2019 17:59:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h5Daf-0003MB-5k for pgsql-hackers@arkaria.postgresql.org; Sat, 16 Mar 2019 17:59:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5Dae-0003G5-Qx for pgsql-hackers@lists.postgresql.org; Sat, 16 Mar 2019 17:59:24 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5Dab-0002Vi-HU for pgsql-hackers@postgresql.org; Sat, 16 Mar 2019 17:59:23 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x2GHx4dF032542; Sat, 16 Mar 2019 13:59:04 -0400 From: Tom Lane To: Jeff Janes cc: Alexander Korotkov , Nikita Glukhov , Tomas Vondra , Andres Freund , Oleg Bartunov , Michael Paquier , Stas Kelvich , PostgreSQL-development , Thomas Munro , David Steele , Andrew Dunstan , Robert Haas , Pavel Stehule Subject: Re: jsonpath In-reply-to: References: <9f5f1247-29f4-17cd-edd9-38e9bcd95b14@postgrespro.ru> <20190130022826.of7w6xv5lbvzqxfp@alap3.anarazel.de> <957ee2ff-f9a6-0ba1-13e2-9c4d320f63ac@2ndquadrant.com> <67128b8b-2d80-9e51-20a8-9ac8e0e2243e@2ndquadrant.com> <220821fb-52c0-c277-0959-322c8eef76b2@postgre! spro.ru> Comments: In-reply-to Jeff Janes message dated "Sat, 16 Mar 2019 13:51:44 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32540.1552759144.1@sss.pgh.pa.us> Date: Sat, 16 Mar 2019 13:59:04 -0400 Message-ID: <32541.1552759144@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Jeff Janes writes: > I think these files have to be cleaned up by "make maintainer-clean" > ./src/backend/utils/adt/jsonpath_gram.c > ./src/backend/utils/adt/jsonpath_scan.c Good point. I also see jsonpath_gram.h left behind after maintainer-clean: $ git status --ignored On branch master Your branch is up-to-date with 'origin/master'. Ignored files: (use "git add -f ..." to include in what will be committed) src/backend/utils/adt/jsonpath_gram.c src/backend/utils/adt/jsonpath_scan.c src/include/utils/jsonpath_gram.h Looks like whoever modified src/backend/Makefile's distprep target didn't bother to read the comment. regards, tom lane