From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Heikki Linnakangas <hlinnaka@iki.fi>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        pgsql-hackers@postgresql.org
Subject: Re: WIP: Faster Expression Processing v4
In-reply-to: <20170320062511.hp5qeurtxrwsvfxr@alap3.anarazel.de>
References: <20161206034955.bh33paeralxbtluv@alap3.anarazel.de>
 <20170209003312.rr7atqepgbrf4xqe@alap3.anarazel.de>
 <20170307030137.lpo4japv5oqgbqpz@alap3.anarazel.de>
 <2090fd00-4dec-7b42-f700-64308958504c@2ndquadrant.com>
 <20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de>
 <fcdaa51b-e905-72e0-39dd-5e22f535a253@2ndquadrant.com>
 <20170314065259.ffef4tfhgbsaieoe@alap3.anarazel.de>
 <69b7bb0e-8dab-3d39-1a89-3c6ab6409f64@iki.fi>
 <20170314224706.nxvtapenky6eom3z@alap3.anarazel.de>
 <13062.1489622943@sss.pgh.pa.us>
 <20170320062511.hp5qeurtxrwsvfxr@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sun, 19 Mar 2017 23:25:11 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32581.1490022972.1@sss.pgh.pa.us>
Date: Mon, 20 Mar 2017 11:16:12 -0400
Message-ID: <32582.1490022972@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Andres Freund <andres@anarazel.de> writes:
> On 2017-03-15 20:09:03 -0400, Tom Lane wrote:
>> I think it would be worth creating a README file giving an overview
>> of how all of this patch is supposed to work.  You also need to do a
>> whole lot more work on the function-level comments.

> I tried to improve upon both fronts.  I've added the higher level
> explanation to executor/README, but I don't feel very strong about that.

> I'm not quite sure it's exactly what you wanted however, the above ask
> could also be understood to have more of an motivational angle,
> describing why and what exactly is changed?  I'm also still not sure how
> understandable it's for anybody that hasn't had their head in this for a
> while...

Well, I wasn't totally sure what was needed either.  I'm coming to this
relatively fresh, having paid little attention to the thread up to now,
so maybe I'll try to add material to what you wrote as I figure things
out.

> Did I understand correctly that you'd rather just merge
> ExecGetLastAttnums into execExpr.c, instead of making it globally
> available?

Yeah, just moving it over seems like the thing to do for now.  We can
expose it later if there proves to be an actual reason to do that,
but as I mentioned, I'm doubtful that there will be one.

I'll start reading these...

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers