Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqLmR-0001ui-LM for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Mar 2017 15:33:03 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cqLmQ-00040U-M7 for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Mar 2017 15:33:02 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cqLks-0000Rq-Q2 for pgsql-hackers@postgresql.org; Tue, 21 Mar 2017 15:31:26 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cqLkq-0008A6-3F for pgsql-hackers@postgresql.org; Tue, 21 Mar 2017 15:31:25 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v2LFV8Yr032633; Tue, 21 Mar 2017 11:31:08 -0400 From: Tom Lane To: Andres Freund cc: Heikki Linnakangas , Tomas Vondra , pgsql-hackers@postgresql.org Subject: Re: WIP: Faster Expression Processing v4 In-reply-to: <20170321063929.24ytp6pqmck34p7f@alap3.anarazel.de> References: <20170307030137.lpo4japv5oqgbqpz@alap3.anarazel.de> <2090fd00-4dec-7b42-f700-64308958504c@2ndquadrant.com> <20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de> <20170314065259.ffef4tfhgbsaieoe@alap3.anarazel.de> <69b7bb0e-8dab-3d39-1a89-3c6ab6409f64@iki.fi> <20170314224706.nxvtapenky6eom3z@alap3.anarazel.de> <13062.1489622943@sss.pgh.pa.us> <20170320062511.hp5qeurtxrwsvfxr@alap3.anarazel.de> <23723.1490040387@sss.pgh.pa.us> <20170321063929.24ytp6pqmck34p7f@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Mon, 20 Mar 2017 23:39:29 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32631.1490110268.1@sss.pgh.pa.us> Date: Tue, 21 Mar 2017 11:31:08 -0400 Message-ID: <32632.1490110268@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Andres Freund writes: > On 2017-03-20 16:06:27 -0400, Tom Lane wrote: >> ... is there a reason why resultnum for EEOP_ASSIGN_* steps is declared >> size_t and not just int? Since it's an array index, and one that >> certainly can't be bigger than AttrNumber, that seems rather confusing. > Not that I can see, no. I guess I might have "overcompensated" when > changing it from AttrNumber - AttrNumber isn't a good idea because that > needs an extra move-zero-extend, because 16bit indexing isn't that well > supported on x86. But that doesn't mean it should be a 64bit number - > to the contrary actually. OK, will fix in the edits I'm working on. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers