Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jRhWh-00036H-1I
	for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Apr 2020 19:28:47 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jRhWf-0002aU-Un
	for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Apr 2020 19:28:45 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jRhWf-0002aJ-Ny
	for pgsql-hackers@lists.postgresql.org; Thu, 23 Apr 2020 19:28:45 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jRhWd-0005n1-Oa
	for pgsql-hackers@postgresql.org; Thu, 23 Apr 2020 19:28:44 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 03NJSehL032659;
	Thu, 23 Apr 2020 15:28:40 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: HEAPDEBUGALL is broken
In-reply-to: <6830.1587565191@sss.pgh.pa.us>
References: <645c0646-4218-d4c3-409a-a7003a0c108d@2ndquadrant.com>
 <3070eb7d-e06d-31a0-5b68-4ae088fd146c@gmail.com>
 <cffb7d94-e7f4-6d45-bd0b-7cca9e2796fb@2ndquadrant.com>
 <8936216c-3492-3f6e-634b-d638fddc5f91@gmail.com>
 <6830.1587565191@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Wed, 22 Apr 2020 10:19:51 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32657.1587670120.1@sss.pgh.pa.us>
Date: Thu, 23 Apr 2020 15:28:40 -0400
Message-ID: <32658.1587670120@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

I wrote:
> Alexander Lakhin <exclusion@gmail.com> writes:
>> So I would just remove this debug macro. The proposed patch is attached.

> I didn't review this in close detail, but I think it's a good idea.

I checked this more closely and pushed it.

			regards, tom lane