Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iaLgT-0003eL-SE for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Nov 2019 15:26:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iaLgS-0003A1-Jf for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Nov 2019 15:26:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iaLgS-00039u-B2 for pgsql-hackers@lists.postgresql.org; Thu, 28 Nov 2019 15:26:20 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iaLgQ-0001IH-6C for pgsql-hackers@lists.postgresql.org; Thu, 28 Nov 2019 15:26:19 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id xASFQF1p032662; Thu, 28 Nov 2019 10:26:15 -0500 From: Tom Lane To: Alvaro Herrera cc: Pg Hackers Subject: Re: remove useless returns In-reply-to: <20191128144653.GA27883@alvherre.pgsql> References: <20191128144653.GA27883@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Thu, 28 Nov 2019 11:46:53 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32660.1574954775.1@sss.pgh.pa.us> Date: Thu, 28 Nov 2019 10:26:15 -0500 Message-ID: <32661.1574954775@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Alvaro Herrera writes: > Here's a silly insomnia-inspired little patch that removes useless > "return;" lines from some routines. +1, I always thought that was poor style. regards, tom lane