Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkx9S-0004OI-L5 for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2023 01:13:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pkx9Q-00034S-E6 for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2023 01:13:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkx9Q-00034I-4h for pgsql-hackers@lists.postgresql.org; Sat, 08 Apr 2023 01:13:56 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pkx9J-001Xvs-2P for pgsql-hackers@lists.postgresql.org; Sat, 08 Apr 2023 01:13:55 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 3381Dh4i3271513; Fri, 7 Apr 2023 21:13:43 -0400 From: Tom Lane To: Dag Lem cc: Tomas Vondra , Andrew Dunstan , Andres Freund , Alvaro Herrera , Paul Ramsey , PostgreSQL Hackers Subject: Re: daitch_mokotoff module In-reply-to: <3135273.1680893728@sss.pgh.pa.us> References: <20230208090954.ngbokgukzx7ooj3m@alvherre.pgsql> <53185f47-ed08-12ef-83d1-0cd26d49a209@enterprisedb.com> <20230211025830.twigy3l65bc27cyw@awork3.anarazel.de> <037c6b65-019e-7e4b-4fd0-77973ea75a9f@enterprisedb.com> <3135273.1680893728@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Fri, 07 Apr 2023 14:55:28 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3271511.1680916423.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 07 Apr 2023 21:13:43 -0400 Message-ID: <3271512.1680916423@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I wrote: > That seems fine to me. I'll check this over and see if I can get > it pushed today. I pushed this after some mostly-cosmetic fiddling. Most of the buildfarm seems okay with it, but crake's perlcritic run is not: ./contrib/fuzzystrmatch/daitch_mokotoff_header.pl: I/O layer ":utf8" used = at line 15, column 5. Use ":encoding(UTF-8)" to get strict validation. (= [InputOutput::RequireEncodingWithUTF8Layer] Severity: 5) Any suggestions on exactly how to pacify that? regards, tom lane