From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Andreas Seltenreich <seltenreich@gmx.de>, pgsql-hackers@postgresql.org
Subject: Re: Failing assertions in indxpath.c, placeholder.c and brin_minmax.c
In-reply-to: <20150728183942.GA2441@postgresql.org>
References: <871tfv3wor.fsf@ex.ansel.ydns.eu> <20646.1437919632@sss.pgh.pa.us>
 <20150728183942.GA2441@postgresql.org>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
 message dated "Tue, 28 Jul 2015 15:39:42 -0300"
Date: Tue, 28 Jul 2015 19:04:10 -0400
Message-ID: <32728.1438124650@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Tom Lane wrote:
>> Bottom line is that somebody failed to consider the possibility of a
>> null comparison value reaching the BRIN index lookup machinery.
>> The code stanza that's failing supposes that only IS NULL or IS NOT NULL
>> tests could have SK_ISNULL set, but that's just wrong.

> I think the easiest way to solve this is to consider that all indexable
> operators are strict, and have the function return false in that case.
> The attached patch implements that.

This looks fine to me as a localized fix.  I was wondering whether we
could short-circuit the index lookup further upstream, but I take it from
your comment about _bt_preprocess_keys that BRIN has no convenient place
for that today.  (Even if it did, I'd still vote for making this change,
for safety's sake.)

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers