Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gmNKz-0004qQ-NS
	for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Jan 2019 18:33:21 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gmNKy-0004fL-3r
	for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Jan 2019 18:33:20 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gmNKx-0004fE-Sr
	for pgsql-hackers@lists.postgresql.org; Wed, 23 Jan 2019 18:33:19 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gmNKv-0004Gm-Lp
	for pgsql-hackers@postgresql.org; Wed, 23 Jan 2019 18:33:19 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x0NIX99G032743;
	Wed, 23 Jan 2019 13:33:10 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Amit Khandekar <amitdkhan.pg@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: ArchiveEntry optional arguments refactoring
In-reply-to: <20190123173613.7jgxkiwxa5zzm2ww@alap3.anarazel.de>
References: <20190123164734.cnt7ho34ygwsav7z@alap3.anarazel.de>
 <201901231658.fls2whf2xypv@alvherre.pgsql>
 <20190123172328.b6trpdpcbzbq4unv@alap3.anarazel.de>
 <5606.1548264726@sss.pgh.pa.us>
 <20190123173613.7jgxkiwxa5zzm2ww@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 23 Jan 2019 09:36:13 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32741.1548268389.1@sss.pgh.pa.us>
Date: Wed, 23 Jan 2019 13:33:09 -0500
Message-ID: <32742.1548268389@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> Btw, do you have an opionion on keeping catId / dumpId outside/inside
> the argument struct?

I'd go for outside, since they're not optional.  Not dead set on that
though.

			regards, tom lane