Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkxMy-0005cB-TN for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2023 01:27:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pkxMx-0005b9-LG for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2023 01:27:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkxMx-0005b0-Bt for pgsql-hackers@lists.postgresql.org; Sat, 08 Apr 2023 01:27:55 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkxMv-00036M-4A for pgsql-hackers@lists.postgresql.org; Sat, 08 Apr 2023 01:27:54 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 3381RlTt3274277; Fri, 7 Apr 2023 21:27:47 -0400 From: Tom Lane To: Andres Freund cc: Dag Lem , Tomas Vondra , Andrew Dunstan , Alvaro Herrera , Paul Ramsey , PostgreSQL Hackers Subject: Re: daitch_mokotoff module In-reply-to: <20230408012532.vrvssdi66rprd3aj@awork3.anarazel.de> References: <20230208090954.ngbokgukzx7ooj3m@alvherre.pgsql> <53185f47-ed08-12ef-83d1-0cd26d49a209@enterprisedb.com> <20230211025830.twigy3l65bc27cyw@awork3.anarazel.de> <037c6b65-019e-7e4b-4fd0-77973ea75a9f@enterprisedb.com> <3135273.1680893728@sss.pgh.pa.us> <3271512.1680916423@sss.pgh.pa.us> <20230408012532.vrvssdi66rprd3aj@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Fri, 07 Apr 2023 18:25:32 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3274275.1680917267.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 07 Apr 2023 21:27:47 -0400 Message-ID: <3274276.1680917267@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2023-04-07 21:13:43 -0400, Tom Lane wrote: >> I pushed this after some mostly-cosmetic fiddling. Most of the >> buildfarm seems okay with it, but crake's perlcritic run is not: >> = >> ./contrib/fuzzystrmatch/daitch_mokotoff_header.pl: I/O layer ":utf8" us= ed at line 15, column 5. Use ":encoding(UTF-8)" to get strict validation.= ([InputOutput::RequireEncodingWithUTF8Layer] Severity: 5) > Unless it's not available with old versions, using :encoding(UTF-8) seem= s > sensible? Yeah, that's the obvious fix, I was just wondering if people with more perl-fu than I have see a problem with it. But I'll go ahead and push that for now. regards, tom lane