From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Jelte Fennema <postgres@jeltef.nl>, Michael Paquier <michael@paquier.xyz>,
        "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
        Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>,
        Magnus Hagander <magnus@hagander.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: <c6f2d8f9-ddac-898f-fd2b-5a1946e40dde@dunslane.net>
References: <3d67bc80-4de2-5ba8-e272-e4ad2e59ba04@dunslane.net> <4ac8f263-f1bb-faa5-a307-1fffe00f0e3e@dunslane.net> <CAGECzQRJrcoxozHh=BRTdLrirFui-3nvdRZru7GGa4F9HJV2Rw@mail.gmail.com> <b8f18576-afc0-d961-b33b-c0fa2e63edeb@dunslane.net> <0f074818-b01a-799f-3c74-5fb5deab1d23@dunslane.net> <CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com> <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net> <OSZPR01MB63100E1C06045FB66B16728BFDA09@OSZPR01MB6310.jpnprd01.prod.outlook.com> <e89d122e-6cf6-d0dc-8fe9-1dfa1de8dcab@dunslane.net> <CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com> <ZEOfzsDrQ1SMOj4Q@paquier.xyz> <582c503b-cd98-1891-ff87-9c8e8ce73ee5@dunslane.net> <CAGECzQTvfpkyyRoGscSuS7ySCEXOO1DCi3eztHQbGEDrj_nt4g@mail.gmail.com> <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net> <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net> <3156045.1687208823@sss.pgh.pa.us> <c6f2d8f9-ddac-898f-fd2b-5a1946e40dde@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Tue, 20 Jun 2023 08:04:39 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3275720.1687266516.1@sss.pgh.pa.us>
Date: Tue, 20 Jun 2023 09:08:36 -0400
Message-ID: <3275721.1687266516@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3275721.1687266516%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2023-06-19 Mo 17:07, Tom Lane wrote:
>> Is koel tracking the right repo?  It just spit up with a bunch of
>> diffs that seem to have little to do with the commit it's claiming
>> caused them:

> Yeah, I changed it so that instead of just checking new commits it would 
> check the whole tree. The problem with the incremental approach is that 
> the next run it might turn green again but the issue would not have been 
> fixed.

Ah.

> I think this is a one-off issue. Once we clean up the tree the problem 
> would disappear and the commits it shows would be correct. I imaging 
> that's going to happen any day now?

I can go fix the problems now that we know there are some (already).
However, if what you're saying is that koel only checks recently-changed
files, that's going to be pretty misleading in future too.  If people
don't react to such reports right away, they'll disappear, no?

			regards, tom lane