Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncSlI-0001bC-LH for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 14:05:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncSlH-0007ZO-Ik for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 14:05:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncSlH-0007Z6-9j for pgsql-hackers@lists.postgresql.org; Thu, 07 Apr 2022 14:05:23 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncSlE-0007VP-Vx for pgsql-hackers@postgresql.org; Thu, 07 Apr 2022 14:05:22 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 237E5Fsv3280725; Thu, 7 Apr 2022 10:05:15 -0400 From: Tom Lane To: Jeff Davis cc: Bharath Rupireddy , Andres Freund , Julien Rouhaud , Robert Haas , "pgsql-hackers@postgresql.org" , Amit Kapila , Simon Riggs Subject: Re: Extensible Rmgr for Table AMs In-reply-to: <2b6e4c0298b51a7dc32cd74b104f43f67880aedb.camel@j-davis.com> References: <721eeefbd24c55015739ea75c0a233345e13e0b5.camel@j-davis.com> <20220201043938.r5s35loehsi27saj@jrouhaud> <20220201124550.gnhpw7iytc4da5tq@jrouhaud> <20220203053418.lj5lzsp7yf2mvspw@jrouhaud> <20220204144801.wuwcansdzz3w2nn3@jrouhaud> <20220204145658.qtcmbsdawvn3lg3b@jrouhaud> <211518ee10e5c37014d3a11d744c1aadc43e9f2c.camel@j-davis.com> <20220328180045.nz3nuy5ea2xpxuax@alap3.anarazel.de> <1ae76bc9910df2fc495173b9bf7ed31223721efe.camel@j-davis.com> <3ac6b783ea57e1310c824e436ab693b304877cf8.camel@j-davis.com> <2b6e4c0298b51a7dc32cd74b104f43f67880aedb.camel@j-davis.com> Comments: In-reply-to Jeff Davis message dated "Wed, 06 Apr 2022 23:15:27 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3280723.1649340315.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 07 Apr 2022 10:05:15 -0400 Message-ID: <3280724.1649340315@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Jeff Davis writes: > I'm happy with this patch and I committed it. wrasse is less happy: ccache /opt/developerstudio12.6/bin/cc -m64 -Xa -v -O findtimezone.o ini= tdb.o localtime.o -L../../../src/port -L../../../src/common -L../../../src= /fe_utils -lpgfeutils -L../../../src/common -lpgcommon -L../../../src/port= -lpgport -L../../../src/interfaces/libpq -lpq -L/home/nm/sw/nopath/uuid= -64/lib -L/home/nm/sw/nopath/openldap-64/lib -Wl,--as-needed -Wl,-R'/home/= nm/farm/studio64v12_6/HEAD/inst/lib' -lpgcommon -lpgport -lxslt -lxml2 -l= pam -lssl -lcrypto -lgssapi_krb5 -lz -lreadline -ltermcap -lnsl -lsocket -= lm -o initdb Undefined first referenced symbol in file RmgrTable initdb.o ld: fatal: symbol referencing errors I think this means the static inline functions you added in xlog_internal.h need to be wrapped in #ifndef FRONTEND. regards, tom lane