From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: SIGQUIT handling, redux
In-reply-to: <20230802162550.6d6ya6k2djpoxplb@awork3.anarazel.de>
References: <1850884.1599601164@sss.pgh.pa.us> <20200909192620.dylomoxknmt6rdb3@alap3.anarazel.de> <110116.1599682140@sss.pgh.pa.us> <113530.1599684626@sss.pgh.pa.us> <116384.1599688841@sss.pgh.pa.us> <141736.1599693895@sss.pgh.pa.us> <320251.1599792006@sss.pgh.pa.us> <394091.1599839575@sss.pgh.pa.us> <20230802162550.6d6ya6k2djpoxplb@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 02 Aug 2023 09:25:50 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3281518.1690994119.1@sss.pgh.pa.us>
Date: Wed, 02 Aug 2023 12:35:19 -0400
Message-ID: <3281519.1690994119@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3281519.1690994119%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2020-09-11 11:52:55 -0400, Tom Lane wrote:
>> It's simple enough that maybe we could back-patch it, once it's
>> aged awhile in HEAD.  OTOH, given the lack of field reports of
>> trouble here, I'm not sure back-patching is worth the risk.

> FWIW, looking at collected stack traces in azure, there's a slow but steady
> stream of crashes below StartupPacketTimeoutHandler. ...
> Unsurprisingly just in versions before 14, where this change went in.
> I think that might be enough evidence for backpatching the commit? I've not
> heard of issues due to the checks in check_on_shmem_exit_lists_are_empty().

I'd be willing to take a look at this in a few weeks when $real_life
is a bit less demanding.  Right before minor releases would likely be
a bad idea anyway.

			regards, tom lane