Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkyel-00046U-5B for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2023 02:50:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pkyej-0005rT-Mh for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2023 02:50:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkyej-0005rJ-9E for pgsql-hackers@lists.postgresql.org; Sat, 08 Apr 2023 02:50:21 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkyeh-0003uK-43 for pgsql-hackers@lists.postgresql.org; Sat, 08 Apr 2023 02:50:20 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 3382oIGa3286098; Fri, 7 Apr 2023 22:50:18 -0400 From: Tom Lane To: Stephen Frost cc: pgsql-hackers@lists.postgresql.org Subject: Re: longfin missing gssapi_ext.h In-reply-to: References: <3282942.1680920692@sss.pgh.pa.us> <3284314.1680921096@sss.pgh.pa.us> Comments: In-reply-to Stephen Frost message dated "Fri, 07 Apr 2023 22:38:33 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3286096.1680922218.1@sss.pgh.pa.us> Date: Fri, 07 Apr 2023 22:50:18 -0400 Message-ID: <3286097.1680922218@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Stephen Frost writes: > Looks like buildfarm animal hake, at least, has a version recent enough > to have gssapi_ext.h ... but still older than 1.11 and therefore > doesn't have the type gss_key_value_element_desc defined, so maybe the > check for gss_store_cred_into would be better? Well, now we're getting into value judgements about which gssapi versions are still worth supporting. Are you really willing to toss overboard all versions that don't support gss_store_cred_into? Or should credential delegation be viewed as an incremental feature that we can support or not? TBH, committing things with significant portability hazards ten hours before feature freeze is not high on my list of good development practices. regards, tom lane