Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1mCrHP-0004bs-Bx
	for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Aug 2021 22:28:27 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1mCrHM-00059r-9a
	for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Aug 2021 22:28:24 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1mCrHM-00059h-24
	for pgsql-hackers@lists.postgresql.org; Sun, 08 Aug 2021 22:28:24 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1mCrHI-00011s-Pn
	for pgsql-hackers@lists.postgresql.org; Sun, 08 Aug 2021 22:28:22 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 178MSD3h3289731;
	Sun, 8 Aug 2021 18:28:14 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
cc: Andrew Dunstan <andrew@dunslane.net>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Joel Jacobson <joel@compiler.org>
Subject: Re: Another regexp performance improvement: skip useless
 paren-captures
In-reply-to: <D6AF940F-C48A-4666-A6E0-B92FC96F0711@enterprisedb.com>
References: <2219936.1628115334@sss.pgh.pa.us>
 <31908a04-f73b-8c5b-ed99-919fd4cd4b54@dunslane.net>
 <2390507.1628174181@sss.pgh.pa.us>
 <2BFE7DFD-8537-4B4E-BC4C-2F265A836651@enterprisedb.com>
 <3173384.1628442278@sss.pgh.pa.us>
 <BDB634FD-2EE5-4697-91A0-1F53E1363D3B@enterprisedb.com>
 <3224306.1628454300@sss.pgh.pa.us>
 <D6AF940F-C48A-4666-A6E0-B92FC96F0711@enterprisedb.com>
Comments: In-reply-to Mark Dilger <mark.dilger@enterprisedb.com>
	message dated "Sun, 08 Aug 2021 13:39:46 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3289729.1628461693.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 08 Aug 2021 18:28:13 -0400
Message-ID: <3289730.1628461693@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/3289730.1628461693%40sss.pgh.pa.us>
Precedence: bulk

Mark Dilger <mark.dilger@enterprisedb.com> writes:
> I have applied your latest patch and do not see any problems with it.  A=
ll my tests pass with no asserts and with no differences in results vs. ma=
ster.  This is a test suite of nearly 1.5 million separate regular express=
ions.

Cool, thanks.  I also tried your millions-of-random-regexps script
and didn't find any difference between the results from HEAD and
those from the v3 patch.

			regards, tom lane