Message-ID: <3292adea-a80e-40d9-9696-69300ad4046f@proxel.se>
Date: Fri, 10 Jul 2026 09:31:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Possible typo in an error message
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <20260710.135226.779226693366680552.horikyota.ntt@gmail.com>
Content-Language: en-US
From: Andreas Karlsson <andreas@proxel.se>
In-Reply-To: <20260710.135226.779226693366680552.horikyota.ntt@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/3292adea-a80e-40d9-9696-69300ad4046f%40proxel.se>
Precedence: bulk

On 7/10/26 06:52, Kyotaro Horiguchi wrote:
> While translating this message, I noticed the following error text:
> 
> parse_jsontable.c:644:
>> errdetail("PATH name was %s not found in nested columns list.",
> 
> Is this perhaps meant to be
> 
> PATH name %s was not found in nested columns list.
> 
> instead?

Agreed, or maybe:

"Path name %s not found in nested columns list."

 From what I can see both forms are used in our error messages.

> Also, I wasn't quite sure whether the uppercase "PATH" in messages
> such as "PATH name" has any particular significance. For the
> translation, I ended up treating it as the ordinary word "path", since
> I couldn't tell whether it was intended to refer to the SQL keyword or
> just the general concept.

Agreed, it does not look like it is a keyword so it should not be 
written in upper case.

> I found another occurrence of the similar wording:
> 
> parse_jsontable.c:324:
>>    errdetail("PATH name mismatch: expected %s but %s is given."

That looks like it should be "Path name" too.

-- 
Andreas Karlsson
Percona