Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1q4pkq-0004Ur-22
	for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Jun 2023 21:22:44 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1q4pko-0001kW-Pc
	for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Jun 2023 21:22:42 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <ilmari@ilmari.org>)
	id 1q4pkn-0001kF-9H
	for pgsql-hackers@lists.postgresql.org; Thu, 01 Jun 2023 21:22:42 +0000
Received: from out5-smtp.messagingengine.com ([66.111.4.29])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ilmari@ilmari.org>)
	id 1q4pkh-003ZBi-OF
	for pgsql-hackers@postgresql.org; Thu, 01 Jun 2023 21:22:40 +0000
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
	by mailout.nyi.internal (Postfix) with ESMTP id 66A1F5C01C0;
	Thu,  1 Jun 2023 17:22:33 -0400 (EDT)
Received: from imap46 ([10.202.2.96])
  by compute2.internal (MEProxy); Thu, 01 Jun 2023 17:22:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc
	:content-type:content-type:date:date:from:from:in-reply-to
	:in-reply-to:message-id:mime-version:references:reply-to:sender
	:subject:subject:to:to; s=fm2; t=1685654553; x=1685740953; bh=ye
	S7weE1YcHK0hjWamWPDLr5wycB0aQRhzF/t0AFEhI=; b=n9q2J38hp/czB3VXCa
	ie3hNb9iLipYL5lCFt6kNrbZJ5NRxk4RuPRgjT4th+NOcC7P5QajRLVqwOjpr33B
	1lbCT3kRHZTHPFX/K4VSMCJqqfxi9XTvEVqy3bwnXuEQFdbQKKs2usQ+mz4QGwtx
	3VYN1VZ7bIVR34UtTquySUz0JfYChq85LR70LIg+eUmlVmL6UOv4iyal6rt1wr30
	zvPvNiFHLsJsGeCwcEWFFDpAztaZM16b7r9PuDO0ToO8k7aOo8702Xq669/lnZKk
	zz5MkK3blGR8Unq2wWPu0gIxfypMD9rJwG18lXycqMFO5aGKgNHDJ5QcdAq5pKB1
	/HNw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:content-type:date:date
	:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
	:message-id:mime-version:references:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm1; t=1685654553; x=1685740953; bh=yeS7weE1YcHK0
	hjWamWPDLr5wycB0aQRhzF/t0AFEhI=; b=FJrnD2B1OdhBf4z883txGjwK9Mcna
	htQzqxVksIjrEOv0Ay4oiGnaDyNWT80RpXwAtVF21LPlGkEulOKSOJ4XIxRSukhd
	0+2c4rore2liv5NrNwyDaqbc5yeAkZnh3r3sD/kqtApyGAfz5P7UH8JPTdo7ujhr
	Nc98KHrFUfzMf21lYL60/a+Me2as/M4yUKr605zdKS+78967e9yGyRBEsj3gq/k4
	gFEJzo0xHgLukqLXlXXaR36wpUaO5qvq16H0VDjBEgCLr5GHyaUm+o8zg2llBKNJ
	jtvmLodlil6sycVD0zW/qMFziwSL2xEChIXezPXUzIfrZbbKEg89soqFw==
X-ME-Sender: <xms:GAx5ZNRm9VbuU5uYxrv_xT4jpMalZoOuhba274xCj8o_TYgBuwSR5g>
    <xme:GAx5ZGxcRWy9Qu5DP4avlHy0dbf_QzQSbMndlMuRcKZzyp7h4zAl1f7sOjNmOt4U5
    96ccUK52YMRoEr2Uqc>
X-ME-Proxy-Cause: 
 gggruggvucftvghtrhhoucdtuddrgedvhedrfeeluddgudeitdcutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpeffrghg
    fhhinhhnucfklhhmrghrihcuofgrnhhnshonkhgvrhcuoehilhhmrghrihesihhlmhgrrh
    hirdhorhhgqeenucggtffrrghtthgvrhhnpeefledtveettdeivdejheekteeuvdekieev
    veetgeelkeektdegtdeigfetfedtveenucffohhmrghinhepnhgvohhnrdhtvggthhenuc
    evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehilhhmrghr
    ihesihhlmhgrrhhirdhorhhg
X-ME-Proxy: <xmx:GQx5ZC26gT2Ek5o2GZy5a8CZOwsIs7OOjBQrQYWuKFT9-YBGOGCCFQ>
    <xmx:GQx5ZFAf4KnAlc_ZSZ13VrO8gLyWddXcgfZatNv6QAOmfBKVyJZwHw>
    <xmx:GQx5ZGj5kiqMiXr45NK1F1LFWhQ-DVJCpl0Ag44o7pMiPOR30UjU_g>
    <xmx:GQx5ZMcwuOj-XZurA9fPefLF91gXMPOJtDbiUfuGLoA9N5y4Ufj9YQ>
Feedback-ID: i1ff147bf:Fastmail
Received: by mailuser.nyi.internal (Postfix, from userid 501)
	id E4D5D2A20080; Thu,  1 Jun 2023 17:22:32 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.9.0-alpha0-447-ge2460e13b3-fm-20230525.001-ge2460e13
Mime-Version: 1.0
Message-Id: <329a690c-1f4e-4759-8018-8ee562c159f0@app.fastmail.com>
In-Reply-To: <CT1MJFE3PEEV.2S08CXLDYMCWP@gonk>
References: <87v8g7s6bf.fsf@wibble.ilmari.org>
 <CT1MJFE3PEEV.2S08CXLDYMCWP@gonk>
Date: Thu, 01 Jun 2023 22:22:12 +0100
From: =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: "Tristan Partin" <tristan@neon.tech>,
 "PostgreSQL Hackers" <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Missing dep on Catalog.pm in meson rules
Content-Type: text/plain
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/329a690c-1f4e-4759-8018-8ee562c159f0%40app.fastmail.com>
Precedence: bulk

On Thu, 1 Jun 2023, at 22:16, Tristan Partin wrote:
> Could you create a variable for the file instead of calling files() 3
> times?
>
>> catalog_pm = files('path/to/Catalog.pm')

Sure, but which meson.build file should it go in? I know nothing about meson variable scoping.

> -- 
> Tristan Partin
> Neon (https://neon.tech)

-- 
- ilmari