Subject: Re: segmentation fault when cassert enabled
To: Amit Kapila <amit.kapila16@gmail.com>, vignesh C <vignesh21@gmail.com>,
 Petr Jelinek <petr.jelinek@2ndquadrant.com>
References: <20191025175929.7e90dbf5@firost> <18714.1572020918@sss.pgh.pa.us>
 <20191105172918.3e32a446@firost>
 <c75077cd-a1a7-9a2d-5dc6-4d3d8acfaafa@2ndquadrant.com>
 <20191125155519.5338e3c9@firost>
 <CAA4eK1+9vQb34faKLJbY6KD62HZOJ5Jm9PzoZGiK_9J7cvyDdw@mail.gmail.com>
 <CALDaNm0kVT3+ku99M6=Wy9X=3=-H8jp_Yt7WVuTraPuREZugxQ@mail.gmail.com>
 <CAA4eK1LGNKWDBQ7ktxfQ6vL=f8t_05b_4pSch4Hr=CNj-S-a7Q@mail.gmail.com>
Cc: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Peter Geoghegan <pg@bowt.ie>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <32a64f45-6c01-d2bf-d90a-49ff4bfedcfb@2ndquadrant.com>
Date: Mon, 16 Dec 2019 13:27:43 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: 
 <CAA4eK1LGNKWDBQ7ktxfQ6vL=f8t_05b_4pSch4Hr=CNj-S-a7Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2019-12-16 11:11, Amit Kapila wrote:
> I agree that this is a timing issue.  I also don't see a way to write
> a reproducible test for this.  However, I could reproduce it via
> debugger consistently by following the below steps.  I have updated a
> few comments and commit messages in the attached patch.
> 
> Peter E., Petr J or anyone else, do you have comments or objections on
> this patch?  If none, then I am planning to commit (and backpatch)
> this patch in a few days time.

The patch seems fine to me.  Writing a test seems hard.  Let's skip it.

The commit message has a duplicate "building"/"built" in the first sentence.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services