public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ivan Kush <[email protected]>
To: Jacob Champion <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: [email protected]
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
Date: Fri, 20 Jun 2025 13:08:35 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAOYmi+nGstyp4OyL8SFCm3dtkBzNJqGwL7xYhe85=j2hhaXAMw@mail.gmail.com>
References: <[email protected]>
<CAOYmi+=Pyf9EuR7dRn46ymV-P9fhUft3qH8mqdS-m9ZksmooEg@mail.gmail.com>
<CAOYmi+mhqahb65y1zXtv60T9=mDYTaepV9b-wq-GHey00zuGOg@mail.gmail.com>
<CA+hUKGJ+WyJ26QGvO_nkgvbxgw+03U4EQ4Hxw+QBft6Np+XW7w@mail.gmail.com>
<CAOYmi+mf+hw7x+E3XkRypEGy=yR3n6zowjjXeXaSK20WxX3UGw@mail.gmail.com>
<CAOYmi+kr-Eh7utEDZBFq8Mc9byLLRF3ZNc0TaHt78SKwB4T5KA@mail.gmail.com>
<CA+hUKGL3yYmKmNHw1wnpuhCbqaiDw1DDUhghEDrh6y97Ygzw9Q@mail.gmail.com>
<CAOYmi+kOyST1DoF1WOMQvf75L56LiLHZR2+3qTJ+QCg2KC8raQ@mail.gmail.com>
<CA+hUKGL59uY=UpCHEmTL6dpzuWJBVf1Kc4bQADYDEWG9ZDCffA@mail.gmail.com>
<CAOYmi+k6HUMK4XQAfnxsmgs1oPOKnchyj2O2a+R7H9jOTU4LPQ@mail.gmail.com>
<CA+hUKG+mUfH81RuYm5fJrOxdm85hvxLEm=KxXm+n-12FJJH9jA@mail.gmail.com>
<CAOYmi+nk-KHGGBHz6BGik4+xHPmyPrwOj3ezSM3F4d=-kH_n2Q@mail.gmail.com>
<CAOYmi+n4EDOOUL27_OqYT2-F2rS6S+3mK-ppWb2Ec92UEoUbYA@mail.gmail.com>
<CAOYmi+nGstyp4OyL8SFCm3dtkBzNJqGwL7xYhe85=j2hhaXAMw@mail.gmail.com>
Hello!
This patch fixes CPPFLAGS, LDFLAGS, LIBS when checking AsyncDNS libcurl
support in configure
Custom parameters and paths to libcurl were mistakenly excluded from
CPPFLAGS, LDFLAGS, and LIBS, although AsyncDNS check was OK.
For example, the command `pkg-config --libs libcurl` gives
`-L/usr/local/lib -lcurl`. LDFLAGS will not contain `-L/usr/local/lib`.
This patch fixes such behaviour.
Test case:
I've tested custom Postgres in an old Debian based Linux distro. This
distro contains old libcurl (< 7.61, package libcurl3) that was compiled
with symbols CURL_OPENSSL_3. So I've installed newer version of
libcurlssl, package libcurl4-openssl-dev, that contains symbols
CURL_OPENSSL_4 and compiled my libcurl version > 7.61.
After compilation during testing some Postgres shared libraries or
binaries that was linked with libcurl showed an error "version
CURL_OPENSSL_3 not found (required by …/libcurl.so.4)"
--
Best wishes,
Ivan Kush
Tantor Labs LLC
Attachments:
[text/x-patch] 0001_oauth_ Fix_CPPFLAGS,_LDFLAGS,_LIBS_when_checking_AsyncDNS_libcurl_support.patch (1.9K, ../[email protected]/2-0001_oauth_%20Fix_CPPFLAGS%2C_LDFLAGS%2C_LIBS_when_checking_AsyncDNS_libcurl_support.patch)
download | inline diff:
From 8a24c24f85c40e2aa0c40afc8f9cd7a19afa66c3 Mon Sep 17 00:00:00 2001
From: Ivan Kush <[email protected]>
Date: Fri, 20 Jun 2025 12:16:47 +0300
Subject: [PATCH] oauth: Fix CPPFLAGS, LDFLAGS, LIBS when checking AsyncDNS libcurl support
Custom parameters and paths to libcurl were mistakenly excluded from CPPFLAGS,
LDFLAGS, and LIBS.
For example, the command `pkg-config --libs libcurl` gives
`-L/usr/local/lib -lcurl`. LDFLAGS will not contain `-L/usr/local/lib`
This patch fixes this.
Author: Ivan Kush <[email protected]>
Author: Lev Nikolaev <[email protected]>
Reviewed-by:
Discussion:
---
config/programs.m4 | 7 +++----
configure | 8 +++-----
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/config/programs.m4 b/config/programs.m4
index 0ad1e58b48d..2556e469323 100644
--- a/config/programs.m4
+++ b/config/programs.m4
@@ -348,9 +348,8 @@ AC_DEFUN([PGAC_CHECK_LIBCURL],
*** The installed version of libcurl does not support asynchronous DNS
*** lookups. Rebuild libcurl with the AsynchDNS feature enabled in order
*** to use it with libpq.])
+ CPPFLAGS=$pgac_save_CPPFLAGS
+ LDFLAGS=$pgac_save_LDFLAGS
+ LIBS=$pgac_save_LIBS
fi
-
- CPPFLAGS=$pgac_save_CPPFLAGS
- LDFLAGS=$pgac_save_LDFLAGS
- LIBS=$pgac_save_LIBS
])# PGAC_CHECK_LIBCURL
diff --git a/configure b/configure
index 4f15347cc95..46a011d1d1b 100755
--- a/configure
+++ b/configure
@@ -12883,12 +12883,10 @@ $as_echo "$pgac_cv__libcurl_async_dns" >&6; }
*** The installed version of libcurl does not support asynchronous DNS
*** lookups. Rebuild libcurl with the AsynchDNS feature enabled in order
*** to use it with libpq." "$LINENO" 5
+ CPPFLAGS=$pgac_save_CPPFLAGS
+ LDFLAGS=$pgac_save_LDFLAGS
+ LIBS=$pgac_save_LIBS
fi
-
- CPPFLAGS=$pgac_save_CPPFLAGS
- LDFLAGS=$pgac_save_LDFLAGS
- LIBS=$pgac_save_LIBS
-
fi
if test "$with_gssapi" = yes ; then
--
2.34.1
view thread (244+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox